Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: circleci: Use go orb #166

Merged
merged 6 commits into from
May 4, 2023
Merged

chore: circleci: Use go orb #166

merged 6 commits into from
May 4, 2023

Conversation

vitsalis
Copy link
Member

@vitsalis vitsalis commented May 2, 2023

No description provided.

@vitsalis vitsalis force-pushed the vitsalis/circleci-executor branch from 13d12c4 to 1c8d4c1 Compare May 2, 2023 10:33
@vitsalis vitsalis changed the title chore: circleci: Separate lint job and use go orb chore: circleci: Use go orb May 2, 2023
@vitsalis
Copy link
Member Author

vitsalis commented May 2, 2023

Getting some weird linting errors when doing the linting on a separate job. Reverted the separate job and kept the go orb change for now.

Copy link
Member

@filippos47 filippos47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitsalis vitsalis merged commit 803f138 into dev May 4, 2023
@vitsalis vitsalis deleted the vitsalis/circleci-executor branch May 4, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants