chore: Add aggressive linting with golangci-lint #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianElvis
approved these changes
Jan 10, 2023
| @@ -34,7 +34,7 @@ func (sc *SentCheckpoints) ShouldSend(epoch uint64) bool { | |||
| return true | |||
| } | |||
| // 2. should resend if some interval has passed since the last sent | |||
| durSeconds := uint(time.Now().Sub(*ckptInfo.ts).Seconds()) | |||
| durSeconds := uint(time.Since(*ckptInfo.ts).Seconds()) | |||
There was a problem hiding this comment.
Wow, the linter can even identify this optimisation! 👏
| @@ -24,8 +24,6 @@ type subscriptions struct { | |||
| zfront *zmq.Socket | |||
| latestEvent time.Time | |||
| active bool | |||
|
|
|||
| sequence []chan *SequenceMsg | |||
There was a problem hiding this comment.
Didn't realise that we are not using this field. 😢 What was it used for? @gusin13
There was a problem hiding this comment.
I realized this got left in refactoring, we were using it before but then started using another channel to publish messages blockEventChan.
gitferry
approved these changes
Jan 11, 2023
| ) | ||
|
|
||
| func readCAFile(cfg *config.BTCConfig) []byte { | ||
| // Read certificate file if TLS is not disabled. | ||
| if !cfg.DisableClientTLS { | ||
| certs, err := ioutil.ReadFile(cfg.CAFile) | ||
| certs, err := os.ReadFile(cfg.CAFile) |
There was a problem hiding this comment.
just curious why this needs to be replaced
There was a problem hiding this comment.
ioutil is deprecated https://pkg.go.dev/io/ioutil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add linting similar to the Babylon repository to the vigilante. There were some unused variables that were removed (or used), so please pay attention to those (especially for zmq).