chore: Replace babylonclient with rpc-client #120
Conversation
|
I was wondering why CI failed because of lacking access to rpc-client even though I have added my user ssh key |
|
@vitsalis many thanks! |
config/config.go
Outdated
| @@ -7,6 +7,7 @@ import ( | |||
| "os" | |||
| "path/filepath" | |||
|
|
|||
| bbnCfg "github.com/babylonchain/rpc-client/config" | |||
There was a problem hiding this comment.
| bbnCfg "github.com/babylonchain/rpc-client/config" | |
| bbncfg "github.com/babylonchain/rpc-client/config" |
I remember Go recommends to use lower case for package names
submitter/submitter.go
Outdated
| @@ -82,17 +82,17 @@ func (s *Submitter) Start() { | |||
| log.Infof("Successfully created the vigilant submitter") | |||
| } | |||
|
|
|||
| func (s *Submitter) GetBabylonClient() (*babylonclient.Client, error) { | |||
| func (s *Submitter) GetBabylonClient() (*bbnclient.Client, error) { | |||
There was a problem hiding this comment.
Do we need to return a concrete client object, or returning an interface is good enough?
There was a problem hiding this comment.
Good point. Thanks!
| @@ -20,4 +20,3 @@ submitter-build: | |||
| mock-gen: | |||
| mkdir -p $(MOCKS_DIR) | |||
| $(MOCKGEN_CMD) -source=btcclient/interface.go -package mocks -destination $(MOCKS_DIR)/btcclient.go | |||
| $(MOCKGEN_CMD) -source=babylonclient/interface.go -package mocks -destination $(MOCKS_DIR)/babylonclient.go | |||
There was a problem hiding this comment.
I somehow feel that the BabylonClient interface should be a part of Vigilante, and every future project that uses Babylon client needs to define its own BabylonClient interface.
In the context of vigilante, the BabylonClient interface could be considered as the expected form of the Babylon client implementation from the vigilante's point of view. Other projects may use different functions of a Babylon client, and thus may have different definitions on this interface. Our rpc-client implementation is expected to implement all of these interfaces, so that it can be fitted into all of these use cases.
Another example would be the expected keeper paradigm in Cosmos SDK and Babylon, where each module defines expected keepers that only have a subset of functions of other keepers.
gitferry
force-pushed
the
use-rpc-client
branch
from
2de3f0d
to
e6d0d41
Compare
This PR removes babylonclient and uses rpc-client instead