feat: add witness signature for segwit tx #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusin13
reviewed
Nov 25, 2022
submitter/relayer/utils.go
Outdated
| return false, nil | ||
| case *btcutil.AddressWitnessPubKeyHash: | ||
| return true, nil | ||
| case *btcutil.AddressWitnessScriptHash: |
There was a problem hiding this comment.
just curious what are ScriptHash and PubKeyHash?
There was a problem hiding this comment.
Basically, with the former, you pay the funds to a customized script, which allows customized locking/unlocking mechanisms. With the latter, you pay the funds to a public key. Anyone with the corresponding private key can unlock the script. For detailed explanation, See here.
gusin13
approved these changes
Nov 25, 2022
gitferry
changed the title
vitsalis
approved these changes
Nov 28, 2022
submitter/relayer/utils.go
Outdated
|
|
||
| func isSegWit(addr btcutil.Address) (bool, error) { | ||
| switch addr.(type) { | ||
| case *btcutil.AddressPubKeyHash: |
There was a problem hiding this comment.
Yeah, sure. Didn't realize we can use it. Thanks!
submitter/relayer/relayer.go
Outdated
|
|
||
| // add signature/witness depending on the type of the previous address | ||
| // if not segwit, add signature; otherwise, add witness | ||
| ok, err := isSegWit(utxo.Addr) |
There was a problem hiding this comment.
Suggested change
| ok, err := isSegWit(utxo.Addr) | |
| segwit, err := isSegWit(utxo.Addr) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add witness signature for constructing a SegWit transaction. Basically, the submitter distinguishes the type of the utxo's address. If it's a SegWit type, then the transaction needs a signature script in the witness field to unlock the utxo, leaving the Signature field empty. For detailed explanation of scripting SegWit transactions, see here