Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow diaper change without any contents #431

Merged
merged 4 commits into from
Apr 16, 2022

Conversation

myxor
Copy link
Contributor

@myxor myxor commented Apr 6, 2022

Fixes #426.

It looks like the model change is enough for this change.

image

@coveralls
Copy link

coveralls commented Apr 6, 2022

Coverage Status

Coverage decreased (-0.03%) to 98.304% when pulling bf064a7 on myxor:426_diaper_without_contents into 0d89574 on babybuddy:master.

@cdubz cdubz temporarily deployed to babybuddy-pr-431 April 9, 2022 02:41 Inactive
@cdubz cdubz temporarily deployed to babybuddy-pr-431 April 9, 2022 02:44 Inactive
@cdubz
Copy link
Member

cdubz commented Apr 9, 2022

This also affects thecard_diaperchange_types card but I'm not totally sure how best to address this change there. The idea of that card is to give a quick useful view of how often the child pee'd and pooped for the past few days (i.e., it's not necessarily about the changes themselves).

Just the total number of changes generally is not really as useful and if a user did not use wet or solid the card would just be empty. But maybe that's OK?

@myxor
Copy link
Contributor Author

myxor commented Apr 10, 2022

Maybe that's okay.
Another idea is that the card could contain a third bar called "empty" or "none" or something to represent the complete number of changes?

@cdubz
Copy link
Member

cdubz commented Apr 10, 2022

Yeah but the "empty"/"none" group gets a little dicey because its also possible for a change to be wet and solid so you could have e.g. three diapers -- two wet and solid and one with none -- and the bar could end up look like 2 wet, 2 solid, 1 none. I guess that is fine though...

@myxor
Copy link
Contributor Author

myxor commented Apr 11, 2022

Would be fine for me.

@cdubz cdubz temporarily deployed to babybuddy-pr-431 April 16, 2022 03:51 Inactive
@cdubz cdubz added the enhancement Feature requests or improvements to existing functionality label Apr 16, 2022
@cdubz cdubz added this to the v1.11.0 milestone Apr 16, 2022
@cdubz cdubz merged commit 81ecff0 into babybuddy:master Apr 16, 2022
@cdubz
Copy link
Member

cdubz commented Apr 16, 2022

Merged! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diaper change without wet/solid
3 participants