Support Fixed server and database roles #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description Babel: Do not dump securityadmin from BBF catalog Extension PR amazon-aurora/babelfish_extensions#67 Task: BABEL-5040 Signed-off-by: ANJU BHARTI <[email protected]>
… (#96) ### Description See babelfish-for-postgresql#447 Handle bbf dump restore changes for babelfish db_accessadmin fixed database role. #### Engine PR: babelfish-for-postgresql#447 #### Extension PR: babelfish-for-postgresql/babelfish_extensions#2970 ### Issues Resolved [List any issues this PR will resolve] ### Check List - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).
Handle dump restore for dbcreator fixed server role by restrict dumping dbcreator catalog entry Extension PR : amazon-aurora/babelfish_extensions#65 Task: BABEL-5115 Signed-off-by: ANJU BHARTI <[email protected]>
Description Handle babelfish dump restore changes for fixed database role db_securityadmin Extension PR : amazon-aurora/babelfish_extensions#70 Signed-off-by: Harsh Lunagariya <[email protected]>
Signed-off-by: Shard Gupta <[email protected]>
shardgupta
force-pushed
the
server-db-fixed-role-5-x
branch
from
e831a95 to
3f20518
Compare
HarshLunagariya
approved these changes
Nov 18, 2024
Comment on lines
+5039
to
+5046
| temp_acl = merge_acl_with_grant(old_acl, | ||
| false, /* is_grant */ | ||
| false, /* grant_option */ | ||
| DROP_RESTRICT, | ||
| list_make1_oid(roleid), | ||
| ACLITEM_ALL_PRIV_BITS, | ||
| sysadminOid, | ||
| ownerId); |
There was a problem hiding this comment.
This is a temporary fix. This will be reworked in the same cycle as a separate issue.
shardgupta
approved these changes
Nov 18, 2024
shardgupta
merged commit 2e0148e
into
babelfish-for-postgresql:BABEL_5_X_DEV__PG_17_X
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.