-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle case when NULL is passed as argument of special functions #415
Merged
Deepesh125
merged 4 commits into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
from
amazon-aurora:substring-3x
Jul 31, 2024
Merged
Handle case when NULL is passed as argument of special functions #415
Deepesh125
merged 4 commits into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
from
amazon-aurora:substring-3x
Jul 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anikait Agrawal <[email protected]>
1 task
sumitj824
reviewed
Jul 30, 2024
Signed-off-by: Anikait Agrawal <[email protected]>
sumitj824
approved these changes
Jul 30, 2024
Deepesh125
approved these changes
Jul 31, 2024
1 task
Deepesh125
approved these changes
Jul 31, 2024
Deepesh125
merged commit Jul 31, 2024
8d1dbb7
into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
2 checks passed
Deepesh125
pushed a commit
to babelfish-for-postgresql/babelfish_extensions
that referenced
this pull request
Jul 31, 2024
…ultibyte character (#2747) This commit aims to fix following issue -- 1. SUBSTRING() function with last argument missing raises strange error message. 2. SUBSTRING() should work on [VAR]BINARY, Image argument. In order to fix these issues, added error message handling in ANTLR parser to throw appropriate error message for different number of arguments. Also, added wrapper function handling for SUBSTRING() function to handle binary datatypes and multibyte characters. Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#415 Task: BABEL- 4118, BABEL- 3658 Signed-off-by: Anikait Agrawal <[email protected]>
Deepesh125
pushed a commit
to babelfish-for-postgresql/babelfish_extensions
that referenced
this pull request
Jul 31, 2024
…ultibyte character (#2815) This commit aims to fix following issue -- 1. SUBSTRING() function with last argument missing raises strange error message. 2. SUBSTRING() should work on [VAR]BINARY, Image argument. In order to fix these issues, added error message handling in ANTLR parser to throw appropriate error message for different number of arguments. Also, added wrapper function handling for SUBSTRING() function to handle binary datatypes and multibyte characters. Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#415 Task: BABEL- 4118, BABEL- 3658 Signed-off-by: Anikait Agrawal <[email protected]>
sharathbp
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Aug 20, 2024
…ultibyte character (babelfish-for-postgresql#2815) This commit aims to fix following issue -- 1. SUBSTRING() function with last argument missing raises strange error message. 2. SUBSTRING() should work on [VAR]BINARY, Image argument. In order to fix these issues, added error message handling in ANTLR parser to throw appropriate error message for different number of arguments. Also, added wrapper function handling for SUBSTRING() function to handle binary datatypes and multibyte characters. Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#415 Task: BABEL- 4118, BABEL- 3658 Signed-off-by: Anikait Agrawal <[email protected]>
staticlibs
pushed a commit
to wiltondb/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 20, 2024
…elfish-for-postgresql#415) Extended definition of report_proc_not_found_error_hook and func_select_candidate_hook to include fargs, which will be used to handle scenario when NULL is passed as Argument to special functions. Extension PR: babelfish-for-postgresql/babelfish_extensions#2747 Signed-off-by: Anikait Agrawal <[email protected]>
staticlibs
pushed a commit
to wiltondb/babelfish_extensions
that referenced
this pull request
Oct 20, 2024
…ultibyte character (babelfish-for-postgresql#2747) This commit aims to fix following issue -- 1. SUBSTRING() function with last argument missing raises strange error message. 2. SUBSTRING() should work on [VAR]BINARY, Image argument. In order to fix these issues, added error message handling in ANTLR parser to throw appropriate error message for different number of arguments. Also, added wrapper function handling for SUBSTRING() function to handle binary datatypes and multibyte characters. Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#415 Task: BABEL- 4118, BABEL- 3658 Signed-off-by: Anikait Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains following changes:
report_proc_not_found_error_hook
andfunc_select_candidate_hook
to includefargs
, which will be used to handle scenario when NULL is passed as Argument to special functions.Extension PR: babelfish-for-postgresql/babelfish_extensions#2747
Authored-by: Anikait Agrawal [email protected]
Signed-off-by: Anikait Agrawal [email protected]
Issues Resolved
BABEL- 4118, BABEL- 3658
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.