Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case when NULL is passed as argument of special functions #415

Conversation

Anikait143
Copy link
Contributor

Description

This PR contains following changes:

  • extended definition of report_proc_not_found_error_hook and func_select_candidate_hook to include fargs, which will be used to handle scenario when NULL is passed as Argument to special functions.

Extension PR: babelfish-for-postgresql/babelfish_extensions#2747

Authored-by: Anikait Agrawal [email protected]
Signed-off-by: Anikait Agrawal [email protected]

Issues Resolved

BABEL- 4118, BABEL- 3658

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Anikait143 Anikait143 requested a review from shah-nirmit July 29, 2024 05:49
@Anikait143 Anikait143 requested a review from sumitj824 July 30, 2024 08:02
@Deepesh125 Deepesh125 merged commit 8d1dbb7 into babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X Jul 31, 2024
2 checks passed
@Anikait143 Anikait143 deleted the substring-3x branch July 31, 2024 14:08
Deepesh125 pushed a commit to babelfish-for-postgresql/babelfish_extensions that referenced this pull request Jul 31, 2024
…ultibyte character (#2747)

This commit aims to fix following issue --

1. SUBSTRING() function with last argument missing raises strange error message.
2. SUBSTRING() should work on [VAR]BINARY, Image argument.

In order to fix these issues,  added error message handling in ANTLR parser to throw appropriate error message for
different number of arguments. Also, added wrapper function handling for SUBSTRING() function to handle binary
datatypes and multibyte characters.

Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#415

Task: BABEL- 4118, BABEL- 3658
Signed-off-by: Anikait Agrawal <[email protected]>
Deepesh125 pushed a commit to babelfish-for-postgresql/babelfish_extensions that referenced this pull request Jul 31, 2024
…ultibyte character (#2815)

This commit aims to fix following issue --

1. SUBSTRING() function with last argument missing raises strange error message.
2. SUBSTRING() should work on [VAR]BINARY, Image argument.

In order to fix these issues,  added error message handling in ANTLR parser to throw appropriate error message for
different number of arguments. Also, added wrapper function handling for SUBSTRING() function to handle binary
datatypes and multibyte characters.

Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#415

Task: BABEL- 4118, BABEL- 3658
Signed-off-by: Anikait Agrawal <[email protected]>
sharathbp pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Aug 20, 2024
…ultibyte character (babelfish-for-postgresql#2815)

This commit aims to fix following issue --

1. SUBSTRING() function with last argument missing raises strange error message.
2. SUBSTRING() should work on [VAR]BINARY, Image argument.

In order to fix these issues,  added error message handling in ANTLR parser to throw appropriate error message for
different number of arguments. Also, added wrapper function handling for SUBSTRING() function to handle binary
datatypes and multibyte characters.

Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#415

Task: BABEL- 4118, BABEL- 3658
Signed-off-by: Anikait Agrawal <[email protected]>
staticlibs pushed a commit to wiltondb/postgresql_modified_for_babelfish that referenced this pull request Oct 20, 2024
…elfish-for-postgresql#415)

Extended definition of report_proc_not_found_error_hook and func_select_candidate_hook to include fargs, which will
be used to handle scenario when NULL is passed as Argument to special functions.

Extension PR: babelfish-for-postgresql/babelfish_extensions#2747

Signed-off-by: Anikait Agrawal <[email protected]>
staticlibs pushed a commit to wiltondb/babelfish_extensions that referenced this pull request Oct 20, 2024
…ultibyte character (babelfish-for-postgresql#2747)

This commit aims to fix following issue --

1. SUBSTRING() function with last argument missing raises strange error message.
2. SUBSTRING() should work on [VAR]BINARY, Image argument.

In order to fix these issues,  added error message handling in ANTLR parser to throw appropriate error message for
different number of arguments. Also, added wrapper function handling for SUBSTRING() function to handle binary
datatypes and multibyte characters.

Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#415

Task: BABEL- 4118, BABEL- 3658
Signed-off-by: Anikait Agrawal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants