Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database does not exists error when is_member(), schema_id() function gets called in parallel query mode. #289

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Fix database does not exists error when is_member(), schema_id() function gets called in parallel query mode. #289

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0385efa
[BABEL-4538] Fix database does not exists error when is_member(), sc…
ahmed-shameem Jan 10, 2024
cdffd62
Modify hooks names
ahmed-shameem Jan 12, 2024
d220647
Address review comments
ahmed-shameem Jan 12, 2024
6888ab2
Address review comments
ahmed-shameem Jan 15, 2024
30feba2
Address review comments
ahmed-shameem Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/backend/access/transam/parallel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@
#define PARALLEL_KEY_RELMAPPER_STATE UINT64CONST(0xFFFFFFFFFFFF000D)
#define PARALLEL_KEY_UNCOMMITTEDENUMS UINT64CONST(0xFFFFFFFFFFFF000E)

/* Hooks for communicating babelfish related information to parallel worker */
InitializeParallelDSM_hook_type InitializeParallelDSM_hook;
ParallelWorkerMain_hook_type ParallelWorkerMain_hook;
ahmed-shameem marked this conversation as resolved.
Show resolved Hide resolved

/* Fixed-size parallel state. */
typedef struct FixedParallelState
{
Expand Down Expand Up @@ -291,6 +295,10 @@ InitializeParallelDSM(ParallelContext *pcxt)
shm_toc_estimate_chunk(&pcxt->estimator, strlen(pcxt->library_name) +
strlen(pcxt->function_name) + 2);
shm_toc_estimate_keys(&pcxt->estimator, 1);

/* Estimate how much we'll need for the babelfish fixed parallel state */
if (MyProcPort->is_tds_conn && InitializeParallelDSM_hook)
(*InitializeParallelDSM_hook) (pcxt, true);
}

/*
Expand Down Expand Up @@ -465,7 +473,12 @@ InitializeParallelDSM(ParallelContext *pcxt)
strcpy(entrypointstate, pcxt->library_name);
strcpy(entrypointstate + lnamelen + 1, pcxt->function_name);
shm_toc_insert(pcxt->toc, PARALLEL_KEY_ENTRYPOINT, entrypointstate);

/* Initialize babelfish fixed-size state in shared memory. */
if (MyProcPort->is_tds_conn && InitializeParallelDSM_hook)
(*InitializeParallelDSM_hook) (pcxt, false);
}

ahmed-shameem marked this conversation as resolved.
Show resolved Hide resolved

/* Restore previous memory context. */
MemoryContextSwitchTo(oldcontext);
Expand Down Expand Up @@ -1478,6 +1491,10 @@ ParallelWorkerMain(Datum main_arg)
relmapperspace = shm_toc_lookup(toc, PARALLEL_KEY_RELMAPPER_STATE, false);
RestoreRelationMap(relmapperspace);

/* Hook for babelfish to restore babelfish fixed parallel state */
if (MyFixedParallelState->babelfish_context && ParallelWorkerMain_hook)
(*ParallelWorkerMain_hook) (toc);

/* Restore uncommitted enums. */
uncommittedenumsspace = shm_toc_lookup(toc, PARALLEL_KEY_UNCOMMITTEDENUMS,
false);
Expand Down
8 changes: 8 additions & 0 deletions src/include/access/parallel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,12 @@ extern void ParallelWorkerMain(Datum main_arg);
/* Below helpers are added to support parallel workers in Babelfish context */
extern bool IsBabelfishParallelWorker(void);

/* Hooks for communicating babelfish related information to parallel worker */
typedef void (*InitializeParallelDSM_hook_type)(ParallelContext *pcxt, bool estimate);
extern PGDLLIMPORT InitializeParallelDSM_hook_type InitializeParallelDSM_hook;

typedef void (*ParallelWorkerMain_hook_type)(shm_toc *toc);
extern PGDLLIMPORT ParallelWorkerMain_hook_type ParallelWorkerMain_hook;


#endif /* PARALLEL_H */
Loading