[valgrind] Invalid read in postquel_sub_params #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in postquel_sub_params there is an invalid read when ran valgrind aganist it. Fixed the invalid read in postquel_sub_params when valgrind ran aganist the fuction by passing the correct values. Task: BABEL-4476 Signed-off-by: vasavi suthapalli <[email protected]>
Deepesh125
reviewed
Dec 12, 2023
| prm->value = MakeExpandedObjectReadOnly(fcinfo->args[i].value, | ||
| prm->isnull, | ||
| get_typlen(0)); | ||
| prm->ptype = 0; |
There was a problem hiding this comment.
This ptype being zero doesn't seem right to me. Btw, this issue seem to be community PG issue, we should report it in the community and try to find the solution collectively.
There was a problem hiding this comment.
agree with @Deepesh125 , @Suthapalli-Ramya-satya-vasavi-srija is there a way we can fix this on the extension? If not, then we may need to report it in the community.
@Deepesh125 more info in the Jira.
There was a problem hiding this comment.
if this is an issue in engine code, we should not fix it in extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously in postquel_sub_params there is an invalid read when ran valgrind aganist it. Fixed the invalid read in postquel_sub_params when valgrind ran aganist the fuction by passing the correct values.
Issues Resolved
BABEL-4476
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.