release sys cache reference after string literal hook #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh-for-postgresql#248) Release syscache reference when returning not null nodes from string literal hook to avoid cache reference leak Engine PR: babelfish-for-postgresql#248 Extension PR: babelfish-for-postgresql/babelfish_extensions#1957 Task: 1940 Signed-off-by: Tanzeel Khan <[email protected]>
1 task
Deepesh125
approved these changes
Nov 10, 2023
Deepesh125
merged commit 474e445
into
babelfish-for-postgresql:BABEL_2_X_DEV__PG_14_X
1 check passed
Deepesh125
pushed a commit
to babelfish-for-postgresql/babelfish_extensions
that referenced
this pull request
Nov 10, 2023
Binary data type simply stores hex codes but when transformed to and from varchar, use of correct encoding becomes important. For example the symbol '™' is stored as 0xE284A2 in UTF-8 enc. while 0x99 in Win encoding From users perspective they must see the hex value which is congruent to their server encoding. To fix this we do necessary encoding to source data in varchar <--> varbinary internal functions. Length checks should be done when data (hex string) is in server encoding. We must also handle the case for string literal to binary types. So we explicitly call the varcharvarbinary conversion when a string literal is being casted to binary data type. Also added CAST functions for sys.BBF_VARBINARY to sys.BBF_BINARY and vice versa these cast are being used in geography and geometry cast functions made necessary changes to geography and geometry casts as well i.e. CAST (CAST ($1 AS sys.VARCHAR) AS sys.bbf_varbinary) --> CAST ($1 AS sys.bbf_varbinary) Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#254 Extension PR: #2009 Task: BABEL-1940 Signed-off-by: Tanzeel Khan <[email protected]> Co-authored-by: Rohit Bhagat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release syscache reference when returning not null nodes from string literal hook to avoid cache reference leak
Engine PR: #254
Extension PR: babelfish-for-postgresql/babelfish_extensions#2009
Issues Resolved
[BABEL-1940]
Sign-off
Signed-off-by: Tanzeel Khan [email protected]
Co-authored-by: Rohit Bhagat [email protected]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.