Do not re-do permission checks on range table for parallel worker #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surendravishnoi
approved these changes
Oct 12, 2023
Deepesh125
merged commit f492997
into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
2 checks passed
Deepesh125
added a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 12, 2023
…belfish-for-postgresql#233) With current design of postgres, workflow of parallel worker looks like something below: ``` -- main node ExecutorRun standard_ExecutorStart InitPlan ExecCheckRTPerms <-- does the permission check on all the range table entries from planner stmt standard_ExecutorRun ExecutePlan . . . ExecGather gather_getnext -- spawns initialises and run parallel workers . . . -- parallel worker ParallelQueryMain ExecutorRun standard_ExecutorStart InitPlan ExecCheckRTPerms <- redo the permission check on same set of table standard_ExecutorRun . . . ``` Here, Main worker would not have spawned the worker if there is any permission check failures on any of the range table. And parallel worker is again doing the permission check on same set of tables which is kind of redundant. So this commit avoid that unnecessary permission check. This change is also helpful when select query or subquery involves T-SQL temp tables. Currently, Babelfish is throwing error like "relation with OID 19401 does not exist" because metadata for temp tables is being stored in ENR metadata (which is backend memory) and is not being shared with parallel worker. So this changes will also avoid such error for temp table from parallel worker. Task: BABEL-4450 Signed-off-by: Dipesh Dhameliya <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 16, 2023
…belfish-for-postgresql#233) With current design of postgres, workflow of parallel worker looks like something below: ``` -- main node ExecutorRun standard_ExecutorStart InitPlan ExecCheckRTPerms <-- does the permission check on all the range table entries from planner stmt standard_ExecutorRun ExecutePlan . . . ExecGather gather_getnext -- spawns initialises and run parallel workers . . . -- parallel worker ParallelQueryMain ExecutorRun standard_ExecutorStart InitPlan ExecCheckRTPerms <- redo the permission check on same set of table standard_ExecutorRun . . . ``` Here, Main worker would not have spawned the worker if there is any permission check failures on any of the range table. And parallel worker is again doing the permission check on same set of tables which is kind of redundant. So this commit avoid that unnecessary permission check. This change is also helpful when select query or subquery involves T-SQL temp tables. Currently, Babelfish is throwing error like "relation with OID 19401 does not exist" because metadata for temp tables is being stored in ENR metadata (which is backend memory) and is not being shared with parallel worker. So this changes will also avoid such error for temp table from parallel worker. Task: BABEL-4450 Signed-off-by: Dipesh Dhameliya <[email protected]>
priyansx
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 22, 2023
…belfish-for-postgresql#233) With current design of postgres, workflow of parallel worker looks like something below: ``` -- main node ExecutorRun standard_ExecutorStart InitPlan ExecCheckRTPerms <-- does the permission check on all the range table entries from planner stmt standard_ExecutorRun ExecutePlan . . . ExecGather gather_getnext -- spawns initialises and run parallel workers . . . -- parallel worker ParallelQueryMain ExecutorRun standard_ExecutorStart InitPlan ExecCheckRTPerms <- redo the permission check on same set of table standard_ExecutorRun . . . ``` Here, Main worker would not have spawned the worker if there is any permission check failures on any of the range table. And parallel worker is again doing the permission check on same set of tables which is kind of redundant. So this commit avoid that unnecessary permission check. This change is also helpful when select query or subquery involves T-SQL temp tables. Currently, Babelfish is throwing error like "relation with OID 19401 does not exist" because metadata for temp tables is being stored in ENR metadata (which is backend memory) and is not being shared with parallel worker. So this changes will also avoid such error for temp table from parallel worker. Task: BABEL-4450 Signed-off-by: Dipesh Dhameliya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With current design of postgres, workflow of parallel worker looks like something below:
Here, Main worker would not have spawned the worker if there is any permission check failures on any of the range table. And parallel worker is again doing the permission check on same set of tables which is kind of redundant. So this commit avoid that unnecessary permission check.
This change is also helpful when select query or subquery involves T-SQL temp tables. Currently, Babelfish is throwing error like "relation with OID 19401 does not exist" because metadata for temp tables is being stored in ENR metadata (which is backend memory) and is not being shared with parallel worker. So this changes will also avoid such error for temp table from parallel worker.
Regression tests run successfully:
Note: One of the test is failing because I had to make changes in test_setup.sql to force parallel query mode.
Task: BABEL-4450
Signed-off-by: Dipesh Dhameliya [email protected]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.