OID Wraparound #232
Closed
OID Wraparound #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timchang514
force-pushed
the
oid-rework
branch
8 times, most recently
from
ce12282 to
2e0ce1b
Compare
timchang514
requested review from
lejaokri,
surendravishnoi,
2jungkook and
robverschoor
robverschoor
suggested changes
Oct 16, 2023
I do plan to add these test cases (see quip doc for full test plan) - as mentioned, we'll need to add new integration tests. So these cases probably can't be part of this PR. One of the issues for example, creating over 64k temp objects in a session will time out in GitHub actions. With our own integration tests we can have more flexibility here. Especially with wraparound, if we're talking about just temp OID wraparound then that will be the same issue, we need to create enough temp objects to wrap around the buffer. General OID wraparound in postgres is even harder to trigger, we'd need to create billions of OIDs. Overlap is difficult to guarantee as well, it would basically necessitate postgres OID wraparound to test. |
|
This is a pretty sizeable code change and I am wondering if it is possible to have some concurrency tests as part of this PR? I am not sure if any of the Github Actions have concurrency tests in them, if not, can we do some manual tests just to verify? Describe the concurrency tests and the results in the Test Plan. |
timchang514
force-pushed
the
oid-rework
branch
from
63d1cd5 to
1656469
Compare
lejaokri
reviewed
Oct 19, 2023
lejaokri
reviewed
Oct 20, 2023
lejaokri
reviewed
Oct 20, 2023
lejaokri
reviewed
Oct 23, 2023
timchang514
force-pushed
the
oid-rework
branch
3 times, most recently
from
acbdbef to
ace3341
Compare
timchang514
force-pushed
the
oid-rework
branch
2 times, most recently
from
81072c0 to
d5634cb
Compare
timchang514
force-pushed
the
oid-rework
branch
from
9926c8a to
ef4ef00
Compare
lejaokri
reviewed
Jan 10, 2024
timchang514
force-pushed
the
oid-rework
branch
from
9fb4b0e to
be3199b
Compare
Signed-off-by: Tim Chang <[email protected]> add full range of OID Remove ability to alter buffer size GUC, correct error messages Remove lc NULL check Remove references to TempVariableCache Revert "Remove lc NULL check" This reverts commit 07c28e5. Add proper check for toast tables Added comments, added OID macros Add temp table utilization warning Use correct backend for index_create workaround Add include
Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
timchang514
force-pushed
the
oid-rework
branch
from
be3199b to
6f36200
Compare
lejaokri
previously approved these changes
Jan 17, 2024
lejaokri
approved these changes
Jan 17, 2024
This was referenced Jan 17, 2024
Merged
|
Closing, this is merged in 16.x only for now. |
1 task
2jungkook
pushed a commit
that referenced
this pull request
Sep 24, 2024
Normal OIDs were still being consumed in some cases during temp table creation even with temp oid buffer on. To fix this, ensure that the appropriate temp table dependent objects also use temp OID. - Redirect type creation functions to use temp OID when it's a TSQL temp table. - Redirect constraint creation to use temp OID in those cases as well. - Remove workaround for indexes on temp tables. Previously, we needed to force indexes on temp tables to consume normal OIDs. With changes described in lines 1+2 above, we can now remove the workaround added in OID Wraparound #232 and properly allow indexes to use temp oid buffer. Task: BABEL-4750 Signed-off-by: Tim Chang <[email protected]>
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 18, 2024
…abelfish-for-postgresql#335) Normal OIDs were still being consumed in some cases during temp table creation even with temp oid buffer on. To fix this, ensure that the appropriate temp table dependent objects also use temp OID. - Redirect type creation functions to use temp OID when it's a TSQL temp table. - Redirect constraint creation to use temp OID in those cases as well. - Remove workaround for indexes on temp tables. Previously, we needed to force indexes on temp tables to consume normal OIDs. With changes described in lines 1+2 above, we can now remove the workaround added in OID Wraparound babelfish-for-postgresql#232 and properly allow indexes to use temp oid buffer. Task: BABEL-4750 Signed-off-by: Tim Chang <[email protected]>
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 18, 2024
…abelfish-for-postgresql#335) Normal OIDs were still being consumed in some cases during temp table creation even with temp oid buffer on. To fix this, ensure that the appropriate temp table dependent objects also use temp OID. - Redirect type creation functions to use temp OID when it's a TSQL temp table. - Redirect constraint creation to use temp OID in those cases as well. - Remove workaround for indexes on temp tables. Previously, we needed to force indexes on temp tables to consume normal OIDs. With changes described in lines 1+2 above, we can now remove the workaround added in OID Wraparound babelfish-for-postgresql#232 and properly allow indexes to use temp oid buffer. Task: BABEL-4750 Signed-off-by: Tim Chang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a separate OID buffer for temp objects. Since temp objects are already session-local, we can allocate a separate buffer of OIDs set aside only for temp objects. This same buffer range can be used across all sessions.
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.