Optimized pgstat_init_function_usage/pg_newlocale_from_collation #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 18, 2023 10:32
…ion in creating index Signed-off-by: Parikshit Sarode <[email protected]>
KushaalShroff
previously requested changes
Aug 29, 2023
forestkeeper
reviewed
Sep 1, 2023
| @@ -40,8 +40,6 @@ int pgstat_track_functions = TRACK_FUNC_OFF; | |||
| */ | |||
| static instr_time total_func_time; | |||
|
|
|||
| pre_function_call_hook_type pre_function_call_hook = NULL; | |||
There was a problem hiding this comment.
We should not delete this hook definition, as it's a community PG code
forestkeeper
reviewed
Sep 1, 2023
forestkeeper
reviewed
Sep 1, 2023
src/backend/utils/adt/pg_locale.c
Outdated
| @@ -1534,6 +1537,11 @@ pg_newlocale_from_collation(Oid collid) | |||
| } | |||
|
|
|||
| cache_entry = lookup_collation_cache(collid, false); | |||
|
|
|||
| if (prev_cache && prev_cache->collid == collid) | |||
There was a problem hiding this comment.
Should wrap those code into a hook, and put the impl into babel code
There was a problem hiding this comment.
Here caching the very previous call using global pointer to avoid hash search. Creating a hook for this may be unnecessary
There was a problem hiding this comment.
We should try our best to make minimal change on PG side
forestkeeper
reviewed
Sep 7, 2023
src/backend/utils/adt/pg_locale.c
Outdated
| } | ||
|
|
||
| prev_cache->collid = cache_entry->collid; | ||
| prev_cache->locale = cache_entry->locale; |
There was a problem hiding this comment.
We should move this part into babel specific too
added 11 commits
September 11, 2023 11:05
Signed-off-by: Parikshit Sarode <[email protected]>
forestkeeper
approved these changes
Sep 26, 2023
forestkeeper
merged commit c7572cd
into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
Sairakan
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 16, 2023
…elfish-for-postgresql#188) * Optimize pgstat_init_function_usage/pg_newlocale_from_collation function in creating index Signed-off-by: Parikshit Sarode <[email protected]> Task: BABEL-4300
priyansx
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 22, 2023
…elfish-for-postgresql#188) * Optimize pgstat_init_function_usage/pg_newlocale_from_collation function in creating index Signed-off-by: Parikshit Sarode <[email protected]> Task: BABEL-4300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In per row execution, when we call func like varncmp or varcmp inside fmgr_security_definer, it'll go through pgstat_init_function_usage in pg_stat_statements and pgstat_init_function_usage did a searchcache everytime when the function is called, this call is avoided in this update. Optimized both the functions by reducing system cache search every time by storing the previous cached values in pgstat_init_function_usage and pg_newlocale_from_collation.
Query execution time reduction is noticed after optimisation on varchar index.
Singned-off-by: Parikshit Sarode [email protected]
Issues Resolved
Optimised function pgstat_init_function_usage and pg_newlocale_from_collation by reducing the SearchSysCache1 calls.
Results
On database with 50000 entries including columns of datatypes -int, varchar, date, money , following results were obtained:
BABEL-4300
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.