Support TSQL PIVOT operator #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lejaokri
reviewed
Oct 27, 2023
Comment on lines
+1758
to
+1763
| bool isPivot; | ||
| struct SelectStmt *srcSql; | ||
| struct SelectStmt *catSql; | ||
| List *value_col_strlist; | ||
| char *pivotCol; | ||
| Node *aggFunc; |
There was a problem hiding this comment.
Since you are adding in new fields to SelectStmt please refer to the following fix by @timchang514 where he fixed a problem with uninitialized value when copying these types of structs. Please check if you need to do the same.
commit 26b4e995d4b69e934c511019ee2175a31227c56a
Author: Tim Chang <[email protected]>
Date: Mon Sep 25 15:14:17 2023 -0400
Add new fields to IntoClause funcs to avoid issues with uninitialized memory. (#219)
Signed-off-by: Tim Chang <[email protected]>
Also, I found your branch based on a really old commit. You may need to rebase.
Add a boolean isPivot in SelectStmt to check if it is a pivot select Task: BABEL-284 Signed-off-by: Yanjie Xu <[email protected]>
Added transformPivotClause function in analyer to help identify output table columns' data type. Task: BABEL-284 Signed-off-by: Yanjie Xu <[email protected]>
Refactor code from engine to extension Task: BABEL-284 Signed-off-by: Yanjie Xu <[email protected]>
forestkeeper
approved these changes
Oct 28, 2023
forestkeeper
approved these changes
Oct 28, 2023
forestkeeper
merged commit ed8d6d1
into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
2 checks passed
Sairakan
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 16, 2023
Add support for PIVOT in babelfish Task: BABEL-284 Signed-off-by: Yanjie Xu <[email protected]>
priyansx
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 22, 2023
Add support for PIVOT in babelfish Task: BABEL-284 Signed-off-by: Yanjie Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings PIVOT operator to Babelfish.
Issues Resolved
Task: BABEL-284
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.