fix conversion of varchar to binary varbinary and vice versa (#248)

Release syscache reference when returning not null nodes from string literal hook to avoid cache reference leak Engine PR: #248 Extension PR: babelfish-for-postgresql/babelfish_extensions#1957 Task: 1940 Signed-off-by: Tanzeel Khan <[email protected]>
babelfish-for-postgresql · Nov 10, 2023 · 3ec0382 · 3ec0382
1 parent 173beb1
commit 3ec0382
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/backend/parser/parse_coerce.c b/src/backend/parser/parse_coerce.c
@@ -329,9 +329,11 @@ coerce_type(ParseState *pstate, Node *node,
 												  targetTypeMod, baseTypeMod,
 												  newcon, DatumGetCString(con->constvalue),
 												  ccontext, cformat, location);
-			if (result) /* runtimer error function returned */
+			if (result)
+			{
+				ReleaseSysCache(baseType);
 				return result;
-
+			}
 			/*
 			 * If the result is NULL, the newcon should be already updated properly.
 			 * Keep advancing the code.