Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark table_constraints_internal() function as parallel safe and set current_db_id for parallel workers #3323

Open
wants to merge 2 commits into
base: BABEL_4_X_DEV
Choose a base branch
from
+6 −3
Open

Mark table_constraints_internal() function as parallel safe and set current_db_id for parallel workers #3323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53408c5
Mark information_schema_tsql.table_constraints_internal() function as…
Dec 26, 2024
4dc6cd4
Set current db_id along with db_name for parallel workers
Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contrib/babelfishpg_tsql/sql/information_schema_tsql.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ BEGIN
OR has_any_column_privilege(r.oid, 'SELECT, INSERT, UPDATE, REFERENCES') );
END;
$$
LANGUAGE plpgsql STABLE;
LANGUAGE plpgsql STABLE PARALLEL SAFE;

/*
* TABLE_CONSTRAINTS view
Expand Down
2 changes: 1 addition & 1 deletion contrib/babelfishpg_tsql/sql/upgrades/babelfishpg_tsql--4.4.0--4.5.0.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11475,7 +11475,7 @@ BEGIN
OR has_any_column_privilege(r.oid, 'SELECT, INSERT, UPDATE, REFERENCES') );
END;
$$
LANGUAGE plpgsql STABLE;
LANGUAGE plpgsql STABLE PARALLEL SAFE;

CREATE OR REPLACE VIEW information_schema_tsql.table_constraints AS
SELECT
Expand Down
5 changes: 4 additions & 1 deletion contrib/babelfishpg_tsql/src/session.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ void
set_cur_db_name_for_parallel_worker(const char* logical_db_name)
{
int len;
int16 db_id;

if (logical_db_name == NULL)
ereport(ERROR,
Expand All @@ -80,13 +81,15 @@ set_cur_db_name_for_parallel_worker(const char* logical_db_name)

Assert(len <= MAX_BBF_NAMEDATALEND);

if(!DbidIsValid(get_db_id(logical_db_name)))
db_id = get_db_id(logical_db_name);
if(!DbidIsValid(db_id))
ereport(ERROR,
(errcode(ERRCODE_UNDEFINED_DATABASE),
errmsg("database \"%s\" does not exist", logical_db_name)));

strncpy(current_db_name, logical_db_name, MAX_BBF_NAMEDATALEND);
current_db_name[len] = '\0';
current_db_id = db_id;
}


Expand Down