Fix sys.columnproperty ordinal

[tanscorpio7]

Description

In sys.columnproperty, the query for ordinal was incorrect. We put the order by clause outside row_number() OVER() clause which means the row_number() was called before ordering the result leading to random output.

As a fix move ORDER BY clause to inside OVER()

Additional an example to show that row_number() OVER() clause is executed before outside ORDER BY.

babelfish_db=# select a, row_number() over() from (select unnest(ARRAY[99, 1]) as a) order by a;
 a  | row_number 
----+------------
  1 |          2
 99 |          1
(2 rows)

babelfish_db=# select a, row_number() over(order by a) from (select unnest(ARRAY[99, 1]) as a);
 a  | row_number 
----+------------
  1 |          1
 99 |          2
(2 rows)

Issues Resolved

[BABEL-5495]

Sign Off

Signed-off-by: Tanzeel Khan [email protected]

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[coveralls]

Pull Request Test Coverage Report for Build 12501344440

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.004%) to 74.855%

---

Files with Coverage Reduction	New Missed Lines	%
contrib/babelfishpg_tds/src/backend/tds/tdsutils.c	2	73.66%

Totals
Change from base Build 12485768578:	-0.004%
Covered Lines:	46569
Relevant Lines:	62212

---

💛 - Coveralls