Display unmapped schema names in error messages BABEL5 #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges. This commit implements a hook function remove_db_name_in_schema and adds test cases. Original unmapped name will be displayed with this commit. Signed-off-by: Chenxiao Wang <[email protected]>
Pull Request Test Coverage Report for Build 12485963728Details
💛 - Coveralls |
tanscorpio7
suggested changes
Dec 25, 2024
| db_name_len = strlen(cur_db_name); | ||
| schema_name_len = strlen(schema_name); | ||
|
|
||
| if (schema_name != NULL && schema_name_len > db_name_len && strncmp(schema_name, cur_db_name, db_name_len) == 0 && schema_name[db_name_len] == '_') { |
There was a problem hiding this comment.
We can look at the babelfish catalog for original schema name instead. we have syscache for it as well. SYSNAMESPACENAME
| * @return - unmapped schema name char * | ||
| */ | ||
| static const char * | ||
| remove_db_name_in_schema(const char *object_name) |
There was a problem hiding this comment.
I think hook should not be called for non tds connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, Babelfish displays the mapped schema names in error messages. This commit implements a hook function remove_db_name_in_schema and adds test cases. Original unmapped name will be displayed with this commit.
Issues Resolved
BABEL-2961
Test Scenarios Covered
Use case based - ✅
Boundary conditions - NA
Arbitrary inputs - NA
Negative test cases - NA
Minor version upgrade tests - NA
Major version upgrade tests - NA
Performance tests - NA
Tooling impact - NA
Client tests - NA
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.