Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test files by removing set_config calls #3302

Open
wants to merge 2 commits into
base: BABEL_5_X_DEV
Choose a base branch
from

Conversation

ahmed-shameem
Copy link
Contributor

Description

As part of #3096, we restricted setting of few configurations like role, migration mode etc. We ignored few files temporarily to get us unblocked.
This commit fixes 3 such test files:

  1. BABEL-1435
  2. BABEL-1446
  3. babelfish_migration-mode-vu-*

Signed-off-by: Shameem Ahmed [email protected]

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ahmed-shameem and others added 2 commits December 24, 2024 06:01
…sql#3181)

As part of babelfish-for-postgresql#3096, we restricted setting of few configurations like role, migration mode etc. We ignored few files temporarily to get us unblocked.
This commit fixes 3 such test files:
1. BABEL-1435
2. BABEL-1446
3. babelfish_migration-mode-vu-*

Signed-off-by: Shameem Ahmed <[email protected]>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12477819088

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.851%

Totals Coverage Status
Change from base Build 12469325195: 0.0%
Covered Lines: 46566
Relevant Lines: 62212

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants