Update physical database name from jdbc_testdb to babelfish_db #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ANJU BHARTI <[email protected]>
Pull Request Test Coverage Report for Build 12296168040Details
💛 - Coveralls |
thephantomthief
approved these changes
Dec 12, 2024
|
Just check if we need to make any change in engine repo. Probably not needed. |
Not needed in engine. |
shardgupta
approved these changes
Dec 13, 2024
shardgupta
merged commit 3c85d27
into
babelfish-for-postgresql:BABEL_5_X_DEV
44 checks passed
anju15bharti
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 13, 2024
…fish-for-postgresql#3243) Before this commit, physical database name was jdbc_testdb. With this commit, physical database name has been changed to babelfish_db to make it uniform. Signed-off-by: [email protected]
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 17, 2024
shardgupta
pushed a commit
that referenced
this pull request
Dec 17, 2024
#3248) Before this commit, physical database name was jdbc_testdb. With this commit, physical database name has been changed to babelfish_db to make it uniform. Minor version upgrade and pg_dump and restore WF contains following changes: * Checked out to latest version before running prepare script to get physical dbname from latest. * Exported physicalDatabaseName as babelfish_db for pg_dump restore WF for version other than latest. Signed-off-by: Anju Bharti <[email protected]>
timchang514
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 17, 2024
…fish-for-postgresql#3243) (babelfish-for-postgresql#3248) Before this commit, physical database name was jdbc_testdb. With this commit, physical database name has been changed to babelfish_db to make it uniform. Minor version upgrade and pg_dump and restore WF contains following changes: * Checked out to latest version before running prepare script to get physical dbname from latest. * Exported physicalDatabaseName as babelfish_db for pg_dump restore WF for version other than latest. Signed-off-by: Anju Bharti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update physical database name to babelfish_db to make it uniform.
Issues Resolved
[List any issues this PR will resolve]
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.