-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSS-ONLY] Update JDBC Framework to run under a single connection #3240
Open
KushaalShroff
wants to merge
18
commits into
babelfish-for-postgresql:BABEL_5_X_DEV
Choose a base branch
from
amazon-aurora:jdbc_recon_5x
base: BABEL_5_X_DEV
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[OSS-ONLY] Update JDBC Framework to run under a single connection #3240
KushaalShroff
wants to merge
18
commits into
babelfish-for-postgresql:BABEL_5_X_DEV
from
amazon-aurora:jdbc_recon_5x
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12505594390Details
💛 - Coveralls |
KushaalShroff
force-pushed
the
jdbc_recon_5x
branch
from
December 12, 2024 14:48
39b0e6d
to
fc71b2b
Compare
KushaalShroff
force-pushed
the
jdbc_recon_5x
branch
from
December 13, 2024 06:34
fc71b2b
to
4d9c36b
Compare
KushaalShroff
changed the title
Update JDBC Framework to run under a single connection
[OSS-ONLY] Update JDBC Framework to run under a single connection
Dec 17, 2024
KushaalShroff
force-pushed
the
jdbc_recon_5x
branch
from
December 17, 2024 13:58
454c6cf
to
0a49264
Compare
KushaalShroff
force-pushed
the
jdbc_recon_5x
branch
from
December 20, 2024 07:40
a7c6dc4
to
81053d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this commit we enforce JDBC framework to use and keep re-using only 1 connection through it's entirety. We enable this only for non-upgrade tests for now.
To do so we execute the sp_reset_connection after each test file, using the same connection object. In case of crossdialect files (.mix) we still keep reusing the the same connection unless the user has specified their own --tsql/--psql connections.
While enabling this we encountered a lot of bugs which we fixed and add explicit tests under Test-sp_reset_connection.mix but there are other issues that using one connections bring with it like the drawback of not able to unload pg_hint_plan from the current session and other bugs. To avoid them from failing we update these test files as .mix files with their own "--tsql" connection which gets disconnected at the end of the file.
Issues Resolved
BABEL-5255
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.