Fix alter table drop column drops trigger on the table #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanscorpio7
force-pushed
the
BABEL_5417
branch
from
f16fcbb to
3a32470
Compare
Signed-off-by: Tanzeel Khan <[email protected]>
tanscorpio7
force-pushed
the
BABEL_5417
branch
from
3a32470 to
d053d16
Compare
Pull Request Test Coverage Report for Build 12282200736Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: Tanzeel Khan <[email protected]>
| @@ -130,7 +130,7 @@ lookup_and_drop_triggers(ObjectAccessType access, Oid classId, | |||
| return; | |||
|
|
|||
| /* We only want to execute this function for the DROP TABLE case */ | |||
| if (classId != RelationRelationId || access != OAT_DROP) | |||
| if (classId != RelationRelationId || access != OAT_DROP || subId != 0) | |||
There was a problem hiding this comment.
pls add a comment for the subId != 0
forestkeeper
merged commit f756df1
into
babelfish-for-postgresql:BABEL_5_X_DEV
44 checks passed
tanscorpio7
added a commit
to tanscorpio7/babelfish_extensions
that referenced
this pull request
Dec 18, 2024
…-postgresql#3225) In postgres trigger and functions are two different objects. You first define a function and then use it in your trigger definition. In babelfish we handle this internally so that for users it feels like a single object. As part of this internal handing we also drop the function created for this trigger as part of post object access hook. Currently the condition for DROP TABLE was incomplete and even for DROP COLUMN we would drop the triggers associated with the table. As a fix add another condition to only execute this internal drop of triggers for DROP TABLE. Issues Resolved: BABEL-5417 Signed-off-by: Tanzeel Khan <[email protected]>
tanscorpio7
added a commit
to tanscorpio7/babelfish_extensions
that referenced
this pull request
Dec 18, 2024
…-postgresql#3225) In postgres trigger and functions are two different objects. You first define a function and then use it in your trigger definition. In babelfish we handle this internally so that for users it feels like a single object. As part of this internal handing we also drop the function created for this trigger as part of post object access hook. Currently the condition for DROP TABLE was incomplete and even for DROP COLUMN we would drop the triggers associated with the table. As a fix add another condition to only execute this internal drop of triggers for DROP TABLE. Issues Resolved: BABEL-5417 Signed-off-by: Tanzeel Khan <[email protected]>
This was referenced Dec 18, 2024
shardgupta
pushed a commit
that referenced
this pull request
Dec 18, 2024
In postgres trigger and functions are two different objects. You first define a function and then use it in your trigger definition. In babelfish we handle this internally so that for users it feels like a single object. As part of this internal handing we also drop the function created for this trigger as part of post object access hook. Currently the condition for DROP TABLE was incomplete and even for DROP COLUMN we would drop the triggers associated with the table. As a fix add another condition to only execute this internal drop of triggers for DROP TABLE. Issues Resolved: BABEL-5417 Signed-off-by: Tanzeel Khan <[email protected]>
shardgupta
pushed a commit
that referenced
this pull request
Dec 18, 2024
In postgres trigger and functions are two different objects. You first define a function and then use it in your trigger definition. In babelfish we handle this internally so that for users it feels like a single object. As part of this internal handing we also drop the function created for this trigger as part of post object access hook. Currently the condition for DROP TABLE was incomplete and even for DROP COLUMN we would drop the triggers associated with the table. As a fix add another condition to only execute this internal drop of triggers for DROP TABLE. Issues Resolved: BABEL-5417 Signed-off-by: Tanzeel Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In postgres trigger and functions are two different objects. You first define a function and then use it in your trigger definition. In babelfish we handle this internally so that for users it feels like a single object. As part of this internal handing we also drop the function created for this trigger as part of post object access hook. Currently the condition for DROP TABLE was incomplete and even for DROP COLUMN we would drop the triggers associated with the table.
As a fix add another condition to only execute this internal drop of triggers for DROP TABLE.
Issues Resolved
[BABEL-5417]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.