Fixed unexpected error print by insert execute #3215
+35
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insert Execute will print unexpected error msg like : 'procedure returned null record' when the procedure executed return 0 rows of records. This commit fixed this issue that will let the insert execute finish normaly without printing out error message in such case. Task: BABEL-5306 Signed-off-by: Zhibai Song <[email protected]>
Pull Request Test Coverage Report for Build 12195420291Details
💛 - Coveralls |
tanscorpio7
reviewed
Dec 6, 2024
| GO | ||
|
|
||
| drop procedure p_5306 | ||
| GO |
There was a problem hiding this comment.
could we also include the nested test case mentioned in the JIRA, Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert Execute will print unexpected error msg like : 'procedure returned null record' when the procedure executed return 0 rows of records.
This commit fixed this issue that will let the insert execute finish normaly without printing out error message in such case.
Task: BABEL-5306
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.