Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db_datawriter should have update privilege on sequences #3210

Merged

Conversation

shalinilohia50
Copy link
Contributor

Description

T-SQL allows member of db_datawriter to get next value from sequence.

Issues Resolved

Task: BABEL-5356
Signed-off-by: Shalini Lohia [email protected]

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@coveralls
Copy link
Collaborator

coveralls commented Dec 5, 2024

Pull Request Test Coverage Report for Build 12184532125

Details

  • 4 of 11 (36.36%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 74.801%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contrib/babelfishpg_tsql/src/dbcmds.c 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tsql/src/dbcmds.c 2 62.89%
Totals Coverage Status
Change from base Build 12183432572: -0.006%
Covered Lines: 46449
Relevant Lines: 62097

💛 - Coveralls

@shardgupta shardgupta merged commit 166e8db into babelfish-for-postgresql:BABEL_5_X_DEV Dec 6, 2024
42 checks passed
@shardgupta shardgupta deleted the update-seq-5x branch December 6, 2024 03:58
anju15bharti pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Dec 9, 2024
…r-postgresql#3210)

T-SQL allows member of db_datawriter to get next value from sequence.
Issues Resolved

Task: BABEL-5356

Signed-off-by: Shalini Lohia [email protected]
anju15bharti pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Dec 12, 2024
…r-postgresql#3210)

T-SQL allows member of db_datawriter to get next value from sequence.
Issues Resolved

Task: BABEL-5356

Signed-off-by: Shalini Lohia [email protected]
anju15bharti pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Dec 12, 2024
…r-postgresql#3210)

T-SQL allows member of db_datawriter to get next value from sequence.
Issues Resolved

Task: BABEL-5356

Signed-off-by: Shalini Lohia [email protected]
shardgupta pushed a commit that referenced this pull request Dec 12, 2024
T-SQL allows member of db_datawriter to get next value from sequence.
Issues Resolved

Task: BABEL-5356

Signed-off-by: Shalini Lohia [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants