-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db_datawriter should have update privilege on sequences #3210
Merged
shardgupta
merged 2 commits into
babelfish-for-postgresql:BABEL_5_X_DEV
from
amazon-aurora:update-seq-5x
Dec 6, 2024
Merged
db_datawriter should have update privilege on sequences #3210
shardgupta
merged 2 commits into
babelfish-for-postgresql:BABEL_5_X_DEV
from
amazon-aurora:update-seq-5x
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalinilohia50
requested review from
HarshLunagariya,
tanscorpio7,
thephantomthief and
rishabhtanwar29
and removed request for
HarshLunagariya
December 5, 2024 17:37
Pull Request Test Coverage Report for Build 12184532125Details
💛 - Coveralls |
tanscorpio7
approved these changes
Dec 5, 2024
HarshLunagariya
approved these changes
Dec 6, 2024
thephantomthief
approved these changes
Dec 6, 2024
shardgupta
approved these changes
Dec 6, 2024
shardgupta
merged commit Dec 6, 2024
166e8db
into
babelfish-for-postgresql:BABEL_5_X_DEV
42 checks passed
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 9, 2024
…r-postgresql#3210) T-SQL allows member of db_datawriter to get next value from sequence. Issues Resolved Task: BABEL-5356 Signed-off-by: Shalini Lohia [email protected]
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 12, 2024
…r-postgresql#3210) T-SQL allows member of db_datawriter to get next value from sequence. Issues Resolved Task: BABEL-5356 Signed-off-by: Shalini Lohia [email protected]
anju15bharti
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 12, 2024
…r-postgresql#3210) T-SQL allows member of db_datawriter to get next value from sequence. Issues Resolved Task: BABEL-5356 Signed-off-by: Shalini Lohia [email protected]
shardgupta
pushed a commit
that referenced
this pull request
Dec 12, 2024
T-SQL allows member of db_datawriter to get next value from sequence. Issues Resolved Task: BABEL-5356 Signed-off-by: Shalini Lohia [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
T-SQL allows member of db_datawriter to get next value from sequence.
Issues Resolved
Task: BABEL-5356
Signed-off-by: Shalini Lohia [email protected]
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.