Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain result type after UNION as base type in T-SQL #3175

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Retain result type after UNION as base type in T-SQL #3175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions contrib/babelfishpg_tsql/src/pltsql_coerce.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
/* Hooks for engine*/
extern find_coercion_pathway_hook_type find_coercion_pathway_hook;
extern determine_datatype_precedence_hook_type determine_datatype_precedence_hook;
extern is_tsql_base_datatype_hook_type is_tsql_base_datatype_hook;
extern func_select_candidate_hook_type func_select_candidate_hook;
extern coerce_string_literal_hook_type coerce_string_literal_hook;
extern select_common_type_hook_type select_common_type_hook;
Expand Down Expand Up @@ -801,6 +802,15 @@ tsql_has_higher_precedence(Oid typeId1, Oid typeId2)
return type1_precedence < type2_precedence;
}

/*
* Returns if given data type is a base type in T-SQL.
*/
static bool
is_tsql_base_datatype(Oid typeId)
{
return tsql_get_type_precedence(typeId) != -1;
}

static bool
is_vectorized_binary_operator(FuncCandidateList candidate)
{
Expand Down Expand Up @@ -2249,6 +2259,7 @@ init_tsql_datatype_precedence_hash_tab(PG_FUNCTION_ARGS)

/* Register Hooks */
determine_datatype_precedence_hook = tsql_has_higher_precedence;
is_tsql_base_datatype_hook = is_tsql_base_datatype;
func_select_candidate_hook = tsql_func_select_candidate;
coerce_string_literal_hook = tsql_coerce_string_literal_hook;
select_common_type_hook = tsql_select_common_type_hook;
Expand Down
6 changes: 3 additions & 3 deletions test/JDBC/expected/BABEL-3392-vu-verify.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1637,7 +1637,7 @@ SELECT name, max_length FROM sys.columns WHERE name = 'babel4157_c1'
GO
~~START~~
varchar#!#smallint
babel4157_c1#!#<NULL>
babel4157_c1#!#3
~~END~~


Expand Down Expand Up @@ -1890,14 +1890,14 @@ select cast(17 as varbinary(1)) UNION select cast(10 as varbinary(2)) union sele
GO
~~ERROR (Code: 33557097)~~

~~ERROR (Message: UNION could not convert type "nchar" to bbf_varbinary)~~
~~ERROR (Message: UNION could not convert type "nchar" to varbinary)~~


SELECT CAST(N'ΘЖऌฒ' AS NCHAR(15)) UNION select cast(10 as varbinary(2));
GO
~~ERROR (Code: 33557097)~~

~~ERROR (Message: UNION could not convert type varbinary to bpchar)~~
~~ERROR (Message: UNION could not convert type varbinary to "nchar")~~


SELECT CAST(1 as BIT) UNION SELECT cast(N'ab' as NCHAR(10)) UNION SELECT CAST('bar' as CHAR(10));
Expand Down
Loading
Loading