Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSS ONLY] Fix to throw error instead of warning in JDBC test logfile #3161

Open
wants to merge 7 commits into
base: BABEL_4_X_DEV
Choose a base branch
from
Open

[OSS ONLY] Fix to throw error instead of warning in JDBC test logfile #3161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0b19b31
enabling extensive logfile
Nov 25, 2024
e9cb341
Merge branch 'babelfish-for-postgresql:BABEL_4_X_DEV' into babel_4939
pranavJ23 Nov 25, 2024
1d9d445
fix
Nov 25, 2024
99ce7cf
temporarily removing secondary server
Nov 25, 2024
b316b08
testing
Nov 26, 2024
1faacd2
testing
Nov 26, 2024
ea1ca04
try changes to get full logfile
Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/composite-actions/install-extensions/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ runs:
if [[ ${{ inputs.server_collation_name }} != "default" ]]; then
sudo echo "babelfishpg_tsql.server_collation_name = '${{ inputs.server_collation_name }}'" >> postgresql.conf
fi
~/${{inputs.install_dir}}/bin/pg_ctl -c -D ~/${{inputs.install_dir}}/$DATADIR/ -l logfile start
~/${{inputs.install_dir}}/bin/pg_ctl -c -D ~/${{inputs.install_dir}}/data/ -l ~/${{inputs.install_dir}}/data/logfile start
cd ~/work/babelfish_extensions/babelfish_extensions/
sudo ~/${{inputs.install_dir}}/bin/psql -v ON_ERROR_STOP=1 -d postgres -U runner -p ${{inputs.psql_port}} -v user="jdbc_user" -v db="jdbc_testdb" -v migration_mode=${{inputs.migration_mode}} -v tsql_port=${{inputs.tsql_port}} -v parallel_query_mode=${{inputs.parallel_query_mode}} -f .github/scripts/create_extension.sql
~/${{inputs.install_dir}}/bin/pg_ctl -c -D ~/${{inputs.install_dir}}/$DATADIR/ -l logfile restart
~/${{inputs.install_dir}}/bin/pg_ctl -c -D ~/${{inputs.install_dir}}/data/ -l ~/${{inputs.install_dir}}/data/logfile restart
sqlcmd -S localhost,${{inputs.tsql_port}} -U "jdbc_user" -P 12345678 -Q "SELECT @@version GO"
shell: bash
22 changes: 11 additions & 11 deletions .github/workflows/jdbc-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,14 @@ jobs:
timeout-minutes: 60
uses: ./.github/composite-actions/run-jdbc-tests

- name: Start secondary server
id: start-secondary
if: always() && steps.jdbc.outcome == 'success'
uses: ./.github/composite-actions/install-extensions
with:
psql_port: 5433
tsql_port: 8199
wal_level: logical
# - name: Start secondary server
# id: start-secondary
# if: always() && steps.jdbc.outcome == 'success'
# uses: ./.github/composite-actions/install-extensions
# with:
# psql_port: 5433
# tsql_port: 8199
# wal_level: logical

- name: Setup Publication and Subscription
id: setup-pub-sub
Expand All @@ -92,14 +92,14 @@ jobs:
sudo ~/psql/bin/psql -d postgres -U runner -v user="jdbc_user" -v db="jdbc_testdb" -f .github/scripts/cleanup_babelfish_database.sql

- name: Upload Log
if: always() && (steps.jdbc.outcome == 'failure' || steps.replication.outcome == 'failure')
if: always()
uses: actions/upload-artifact@v4
with:
name: postgres-log-jdbc
path: |
~/psql/data/logfile
~/psql/data_5433/logfile

# ~/psql/data_5433/logfile
# if: always() && (steps.jdbc.outcome == 'failure' || steps.replication.outcome == 'failure')
# The test summary files contain paths with ':' characters, which is not allowed with the upload-artifact actions
- name: Rename Test Summary Files
id: test-file-rename
Expand Down
Loading