Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fixed database role db_ddladmin (#71) #3130

Merged

Conversation

anju15bharti
Copy link
Contributor

@anju15bharti anju15bharti commented Nov 19, 2024

Original Extension PR : amazon-aurora#71

Engine PR for this commit: babelfish-for-postgresql/postgresql_modified_for_babelfish#476

Support fixed database role db_ddladmin

Engine PR : amazon-aurora/postgresql_modified_for_babelfish#101

Task : BABEL-5116

Signed-off-by: Tanzeel Khan [email protected]
Co-authored-by: Harsh Lunagaria [email protected]
@coveralls
Copy link
Collaborator

coveralls commented Nov 19, 2024

Pull Request Test Coverage Report for Build 11916733938

Details

  • 153 of 189 (80.95%) changed or added relevant lines in 8 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 74.574%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contrib/babelfishpg_tsql/src/multidb.c 12 13 92.31%
contrib/babelfishpg_tsql/src/catalog.c 21 23 91.3%
contrib/babelfishpg_tsql/src/hooks.c 56 58 96.55%
contrib/babelfishpg_tsql/src/pl_handler.c 21 23 91.3%
contrib/babelfishpg_tsql/src/dbcmds.c 27 56 48.21%
Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tsql/src/dbcmds.c 3 63.1%
contrib/babelfishpg_tsql/src/catalog.c 3 85.38%
Totals Coverage Status
Change from base Build 11894064734: 0.01%
Covered Lines: 45760
Relevant Lines: 61362

💛 - Coveralls

Signed-off-by: ANJU BHARTI <[email protected]>
@shardgupta shardgupta merged commit fae2daf into babelfish-for-postgresql:BABEL_5_X_DEV Nov 19, 2024
42 checks passed
@shardgupta shardgupta deleted the ddladmin-5-x branch November 19, 2024 16:56
anju15bharti added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Dec 5, 2024
Support fixed database role db_ddladmin

Engine PR : amazon-aurora/postgresql_modified_for_babelfish#101

Task : BABEL-5116

Signed-off-by: Tanzeel Khan [email protected]
anju15bharti added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Dec 12, 2024
Support fixed database role db_ddladmin

Engine PR : amazon-aurora/postgresql_modified_for_babelfish#101

Task : BABEL-5116

Signed-off-by: Tanzeel Khan [email protected]
anju15bharti added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Dec 12, 2024
Support fixed database role db_ddladmin

Engine PR : amazon-aurora/postgresql_modified_for_babelfish#101

Task : BABEL-5116

Signed-off-by: Tanzeel Khan [email protected]
shardgupta pushed a commit that referenced this pull request Dec 12, 2024
Support fixed database role db_ddladmin

Engine PR : amazon-aurora/postgresql_modified_for_babelfish#101

Task : BABEL-5116

Signed-off-by: Tanzeel Khan [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants