Fix regression in FOR JSON AUTO with nested queries. #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of nested FOR JSON AUTO relied on the happy accident that the enum T_JsonArrayQueryConstructor happened to have the same value as the typid for the json type, 114. In PG17 the enum value for T_JsonArrayQueryConstructor changed to 130, leading to errors when trying to evaluate nested FOR JSON AUTO queries. Fix this by properly using the typid for json. Task: BABEL-5398 Signed-off-by: Jason Teng <[email protected]>
roshan0708
force-pushed
the
bbf-fixes-pg17
branch
from
0147507 to
0558cdd
Compare
Pull Request Test Coverage Report for Build 11856311104Details
💛 - Coveralls |
shardgupta
approved these changes
Nov 15, 2024
shardgupta
merged commit e47fa84
into
babelfish-for-postgresql:BABEL_5_X_DEV
42 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick commit to fix test failures for
forjsonautoJDBC test.Issues Resolved
BABEL-5398
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.