Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inital commit for Babelfish v2.12 #3051

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Inital commit for Babelfish v2.12 #3051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7e79f9
Inital commit for Babelfish v2.12
Oct 24, 2024
cb00f3a
Update babelfish_version.h
thephantomthief Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/configuration/upgrade-test-configuration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ upgrade-version: [{
{
upgrade-path: [
{
version: '14.13',
version: '14.14',
upgrade-type: null
},
{
Expand Down
3 changes: 3 additions & 0 deletions .github/template/version-branch-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@
'14.13':
engine_branch: BABEL_2_10_STABLE__PG_14_13
extension_branch: BABEL_2_10_STABLE
'14.14':
engine_branch: BABEL_2_11_STABLE__PG_14_14
extension_branch: BABEL_2_11_STABLE
'source.latest':
engine_branch: latest
extension_branch: latest
Expand Down
2 changes: 1 addition & 1 deletion contrib/babelfishpg_tsql/Version.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
# places during the build process

PGTSQL_MAJOR_VERSION=2
PGTSQL_MINOR_VERSION=11
PGTSQL_MINOR_VERSION=12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update babelfish_version.h

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

PGTSQL_MICRO_VERSION=0

19 changes: 19 additions & 0 deletions contrib/babelfishpg_tsql/sql/upgrades/babelfishpg_tsql--2.11.0--2.12.0.sql
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we expecting SQL changes to be backpatched to 14? We should confirm this first, otherwise no need to have an empty upgrade script.

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
-- complain if script is sourced in psql, rather than via ALTER EXTENSION
\echo Use "ALTER EXTENSION ""babelfishpg_tsql"" UPDATE TO '2.12.0'" to load this file. \quit

-- add 'sys' to search path for the convenience
SELECT set_config('search_path', 'sys, '||current_setting('search_path'), false);

-- Please add your SQLs here
/*
* Note: These SQL statements may get executed multiple times specially when some features get backpatched.
* So make sure that any SQL statement (DDL/DML) being added here can be executed multiple times without affecting
* final behaviour.
*/


-- After upgrade, always run analyze for all babelfish catalogs.
CALL sys.analyze_babelfish_catalogs();

-- Reset search_path to not affect any subsequent scripts
SELECT set_config('search_path', trim(leading 'sys, ' from current_setting('search_path')), false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: newline

4 changes: 2 additions & 2 deletions contrib/babelfishpg_tsql/src/babelfish_version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*-------------------------------------------------------------------------
*/

#define BABELFISH_VERSION_STR "2.11.0"
#define BABELFISH_INTERNAL_VERSION_STR "Babelfish 14.14.0.0"
#define BABELFISH_VERSION_STR "2.12.0"
#define BABELFISH_INTERNAL_VERSION_STR "Babelfish 14.15.0.0"
#define BABEL_COMPATIBILITY_VERSION "12.0.2000.8"
#define BABEL_COMPATIBILITY_MAJOR_VERSION "12"
Loading
Loading