Comprehensive cursor state cleanup to avoid stale data after TDSResetConnection #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KushaalShroff
force-pushed
the
cursor_reset_4X
branch
from
8250eb4 to
117cffd
Compare
Pull Request Test Coverage Report for Build 11550988613Details
💛 - Coveralls |
kuntalghosh
requested changes
Oct 28, 2024
KushaalShroff
force-pushed
the
cursor_reset_4X
branch
from
ecc1dc4 to
f1913fc
Compare
kuntalghosh
approved these changes
Oct 28, 2024
KushaalShroff
merged commit e4bde8f
into
babelfish-for-postgresql:BABEL_4_X_DEV
46 checks passed
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 22, 2024
…Connection (babelfish-for-postgresql#3040) Earlier we were not cleaning up cursor states and hast tables like CursorHashTable and CursorPreparedHandleHashTable at the time of resetting the TDS connection. This lead to cursor leaks and potentially will let users to continue using the cursors from previous connection. To fix this we introduce a reset_cached_cursor function which cleans up all the stale cursor states and resets the cursor handles. Issues Resolved BABEL-5287 Signed-off-by: Kushaal Shroff [email protected]
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 22, 2024
…Connection (babelfish-for-postgresql#3040) Earlier we were not cleaning up cursor states and hast tables like CursorHashTable and CursorPreparedHandleHashTable at the time of resetting the TDS connection. This lead to cursor leaks and potentially will let users to continue using the cursors from previous connection. To fix this we introduce a reset_cached_cursor function which cleans up all the stale cursor states and resets the cursor handles. Issues Resolved BABEL-5287 Signed-off-by: Kushaal Shroff [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier we were not cleaning up cursor states and hast tables like CursorHashTable and CursorPreparedHandleHashTable at the time of resetting the TDS connection. This lead to cursor leaks and potentially will let users to continue using the cursors from previous connection. To fix this we introduce a reset_cached_cursor function which cleans up all the stale cursor states and resets the cursor handles.
Issues Resolved
BABEL-5287
Test Scenarios Covered
Added tests for prepared and unprepared cursor with thorough checks pre and post reset.
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.