Fix build warnings in sys_functions.sql and babelfishpg_tsql.sql #3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In sys_functions.sql file, we have defined the sys.is_member() function
which internally calls CHARINDEX('\', ...). During build, the compiler
treats \' as an escaped quote and thus complains that there is
unterminated quote. To fix this, added a single quote as a comment.
Signed-off-by: Sharu Goel <[email protected]>
Pull Request Test Coverage Report for Build 11548870192Details
💛 - Coveralls |
|
Three other similar warnings in extension build. |
Signed-off-by: Sharu Goel <[email protected]>
thephantomthief
changed the title
tanscorpio7
approved these changes
Oct 21, 2024
added 3 commits
October 21, 2024 05:54
Signed-off-by: Sharu Goel <[email protected]>
This reverts commit 3739c0e.
shalinilohia50
approved these changes
Oct 21, 2024
added 3 commits
October 21, 2024 06:34
kuntalghosh
approved these changes
Oct 28, 2024
kuntalghosh
merged commit 27ce17a
into
babelfish-for-postgresql:BABEL_4_X_DEV
46 checks passed
Deepesh125
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 28, 2024
…elfish-for-postgresql#3030) In sys_functions.sql file, we have defined the sys.is_member() function which internally calls CHARINDEX('\', ...). During build, the compiler treats \' as an escaped quote and thus complains that there is unterminated quote. To fix this, added a single quote as a comment. Task: BABEL-5359 Signed-off-by: Sharu Goel <[email protected]>
thephantomthief
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Oct 28, 2024
In sys_functions.sql file, we have defined the sys.is_member() function
which internally calls CHARINDEX('\', ...). During build, the compiler
treats \' as an escaped quote and thus complains that there is
unterminated quote. To fix this, added a single quote as a comment.
Task: BABEL-5359
Signed-off-by: Sharu Goel <[email protected]>
shardgupta
pushed a commit
that referenced
this pull request
Oct 28, 2024
In sys_functions.sql file, we have defined the sys.is_member() function
which internally calls CHARINDEX('\', ...). During build, the compiler
treats \' as an escaped quote and thus complains that there is
unterminated quote. To fix this, added a single quote as a comment.
Task: BABEL-5359
Signed-off-by: Sharu Goel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In sys_functions.sql and babelfishpg_tsql.sql files, we have defined
the system objects that internally reference the string '\'. During
build, the compiler treats \' as an escaped quote and thus complains
that there is an unterminated quote. To fix this, added a single quote
as a comment at relevant lines.
Task: BABEL-5359
Signed-off-by: Sharu Goel [email protected]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.