Adding fix for edge cases in Space function #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#2742) Currently for string function SPACE() we only handle positive integers and throws error for input 0 or negative number. This commit will handle those edge cases and when a negative number is passed we will return NULL and when 0 is passed we will return an empty string. Additionally, this commit adds handling when input integer is greater than 8000. Task: BABEL-4811 Signed-off-by: Tanya Gupta <[email protected]>
Signed-off-by: Tanya Gupta <[email protected]>
schedule file Signed-off-by: Tanya Gupta <[email protected]>
Pull Request Test Coverage Report for Build 10158728727Details
💛 - Coveralls |
tanyagupta17
changed the title
Signed-off-by: Tanya Gupta <[email protected]>
jsudrik
merged commit ad03399
into
babelfish-for-postgresql:BABEL_3_X_DEV
42 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently for string function SPACE() we only handle positive integers and throws error for input 0 or negative number. This PR will handle those edge cases and when a negative number is passed we will return NULL and when 0 is passed we will return an empty string. Additionally, this commit adds handling when input integer is greater than 8000.
Cherry-picked from: #2742
Signed-off-by: Tanya Gupta [email protected]
Issues Resolved
BABEL-4811
Test Scenarios Covered
Use case based - YES
Boundary conditions - YES
Arbitrary inputs - YES
Negative test cases - YES
Minor version upgrade tests - YES
Major version upgrade tests - YES
Performance tests - NO
Tooling impact - NO
Client tests - NO
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.