Test changes for 'Fix error when trying to drop columns from temp tables.' #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 18, 2024 19:16
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
timchang514
reviewed
Jul 18, 2024
| CREATE TABLE #t1 (a INT, b INT) | ||
| GO | ||
|
|
||
| ALTER TABLE #t1 DROP COLUMN b |
There was a problem hiding this comment.
can we add more tests, such as
- dropping then recreating the same column multiple times
- make sure that dependencies aren't broken (so if the column depends on another object, or an object depends on the column that the proper behavior happens)
- more complicated dependencies such as with toast/index/identity etc
- ensure that the table also works (i can select, update, drop from it normally)
There was a problem hiding this comment.
Added more test cases. Note that foreign key constraints are not allowed for temp tables, so I can't test that.
Pull Request Test Coverage Report for Build 10047842090Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: Jason Teng <[email protected]>
Sairakan
changed the title
lejaokri
reviewed
Jul 22, 2024
Comment on lines
-156
to
-159
| ~~ERROR (Code: 3726)~~ | ||
|
|
||
| ~~ERROR (Message: cannot drop column b of table "#temp_table_rollback_t1" because other objects depend on it)~~ | ||
|
|
There was a problem hiding this comment.
thanks for handling this.
Do we have tests for scenarios where it's supposed to fail with this error?
There was a problem hiding this comment.
I just added an extra test case, that while not reproducing this exact error, produces a similar error due to a dependency.
1 task
Signed-off-by: Jason Teng <[email protected]>
lejaokri
approved these changes
Jul 22, 2024
2jungkook
merged commit 6b45d49
into
babelfish-for-postgresql:BABEL_4_X_DEV
43 checks passed
Sairakan
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jul 24, 2024
…les.' (babelfish-for-postgresql#2753) Tests for babelfish-for-postgresql/postgresql_modified_for_babelfish#410 Task: BABEL-4912 Signed-off-by: Jason Teng <[email protected]>
2jungkook
pushed a commit
that referenced
this pull request
Jul 24, 2024
…les.' (#2753) (#2779) Tests for babelfish-for-postgresql/postgresql_modified_for_babelfish#410 Task: BABEL-4912 Signed-off-by: Jason Teng <[email protected]>
sharathbp
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Aug 20, 2024
…les.' (babelfish-for-postgresql#2753) Tests for babelfish-for-postgresql/postgresql_modified_for_babelfish#410 Task: BABEL-4912 Signed-off-by: Jason Teng <[email protected]>
staticlibs
pushed a commit
to wiltondb/babelfish_extensions
that referenced
this pull request
Oct 20, 2024
…les.' (babelfish-for-postgresql#2753) (babelfish-for-postgresql#2779) Tests for babelfish-for-postgresql/postgresql_modified_for_babelfish#410 Task: BABEL-4912 Signed-off-by: Jason Teng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests for babelfish-for-postgresql/postgresql_modified_for_babelfish#410
Issues Resolved
BABEL-4912
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.