Added escape hatch for IDENTITY() in select into #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakshi-mittal
requested review from
forestkeeper,
xhfanhe,
wboettge and
RIC06X
| else | ||
| { | ||
| ereport(ERROR, | ||
| (errcode(ERRCODE_SYNTAX_ERROR), |
There was a problem hiding this comment.
Added here because contrib/babelfishpg_tsql/src/tsqlUnsupportedFeatureHandler.cpp has no check for Into() yet. Can be done through that also but will need more changes
deepakshi-mittal
changed the title
Need this because identity column will always be the last one in table if created using a select into statement Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
Updated file BABEL-UNSUPPORTED, Added escape_hatch_identity_function Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
deepakshi-mittal
force-pushed
the
BABEL-539-escape-hatch
branch
from
8d7289b to
0873d84
Compare
forestkeeper
merged commit 9237ce8
into
babelfish-for-postgresql:BABEL_3_X_DEV
29 checks passed
deepakshi-mittal
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 27, 2023
…resql#2055) Need this because identity column will always be the last one in table if created using a select into statement Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]> (cherry picked from commit 9237ce8)
This was referenced Nov 27, 2023
forestkeeper
pushed a commit
that referenced
this pull request
Nov 29, 2023
…ABLE (#2069) Need this because identity column will always be the last one in table if created using a select into statement Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]> (cherry picked from commit 9237ce8)
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 21, 2023
…resql#2055) Need this because identity column will always be the last one in table if created using a select into statement Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 24, 2023
…resql#2055) Need this because identity column will always be the last one in table if created using a select into statement Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 24, 2023
…resql#2055) Need this because identity column will always be the last one in table if created using a select into statement Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 24, 2023
…resql#2055) Need this because identity column will always be the last one in table if created using a select into statement Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added escape_hatch_identity_function for IDENTITY() in select into
Need this because identity column will always be the last one in table if created using a select into statement
Task: BABEL-539 and BABEL-4388
Description
Added escape_hatch_identity_function for IDENTITY() in select into
Related pr: #1967
Issues Resolved
BABEL-539, BABEL-4388
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.