Fix MVU failure due to sys.format_datetime, sys.format_numeric and sys.format functions #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the description, use babelfish version instead of 14_10 |
Deepesh125
requested changes
Nov 16, 2023
Comment on lines
4152
to
4154
| ALTER FUNCTION sys.format_datetime(anyelement, NVARCHAR, VARCHAR, VARCHAR) RENAME TO format_datetime_deprecated_3_4_0; | ||
| ALTER FUNCTION sys.format_numeric(anyelement, NVARCHAR, VARCHAR, VARCHAR, int) RENAME TO format_numeric_deprecated_3_4_0; | ||
| ALTER FUNCTION sys.FORMAT(anyelement, NVARCHAR, VARCHAR) RENAME TO format_deprecated_3_4_0; |
There was a problem hiding this comment.
Separate out these three in different blocks
Deepesh125
approved these changes
Nov 16, 2023
basasairohan
changed the title
Deepesh125
merged commit 386c8c7
into
babelfish-for-postgresql:BABEL_3_X_DEV
28 checks passed
basasairohan
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 16, 2023
…s.format functions (babelfish-for-postgresql#2023) We are deprecating the older versions of sys.format_datetime, sys.format_numeric and sys.format functions in the version 2.7.0, Hence while doing major version upgrade, sys.format_datetime(anyelement, nvarchar, character varying, character varying) is not found. And similarly, sys.format_numeric(anyelement, NVARCHAR, VARCHAR, VARCHAR, int) and sys.format(anyelement, NVARCHAR, VARCHAR) are also deprecated in older version which may cause an error. This changes catches the above error and deprecates the format functions only when they exist. Task: BABEL-4394 Signed-off-by: Sai Rohan Basa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are deprecating the older versions of sys.format_datetime, sys.format_numeric and sys.format functions in 2.7.0, Hence while doing major version upgrade
sys.format_datetime(anyelement, nvarchar, character varying, character varying)is not found.This changes catches the above error and deprecates the format functions only when they exist.
Signed-off-by: Sai Rohan Basa [email protected]
Issues Resolved
BABEL-4394
Test Scenarios Covered
Use case based - N/A
Boundary conditions - N/A
Arbitrary inputs - N/A
Negative test cases - N/A
Minor version upgrade tests - N/A
Major version upgrade tests - N/A
Performance tests - N/A
Tooling impact - N/A
Client tests - N/A
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.