fix crash in fixeddecimalaggstateserialize and fixeddecimalaggstatedeserialize for parallel queries #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serialize for parallel queries In parallel query context, variables state and sstate can be NULL in functions fixeddecimalaggstateserialize and fixeddecimalaggstatedeserialize respectively. This scenario was not handled properly in functions fixeddecimalaggstateserialize and fixeddecimalaggstatedeserialize. This PR adds a check in these functions which will handle this NULL value scenario. Task: BABEL-4261 Signed-off-by: Rohit Bhagat <[email protected]>
Deepesh125
previously approved these changes
Nov 9, 2023
…#1604) * Fix backward scan flag for parallel queries Currently there is a bug in Babelfish that allows the backward scan flag to be set for parallel queries. However, backward scans cannot be parallelized. This bug results in assertion failures in the Postgres engine and leads Babelfish queries to crash. In this commit, we fix the issue by disallowing backward scan flag to be set when a query is in parallel mode. This issue occurs during the implementation of full text search in Babelfish. Fixing the issue unblocks full text search implementation. Task: BABEL-4261, BABEL-4281 Signed-off-by: Robin Li <[email protected]>
1 task
added 5 commits
November 9, 2023 10:36
…stgresql#1604)" This reverts commit f339cff. Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
…ashing Signed-off-by: Rohit Bhagat <[email protected]>
…it is crashing" This reverts commit 29dff26.
Deepesh125
approved these changes
Nov 10, 2023
Deepesh125
merged commit 8be0ec9
into
babelfish-for-postgresql:BABEL_2_X_DEV
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In parallel query context, variables
stateandsstatecan beNULLin functionsfixeddecimalaggstateserializeandfixeddecimalaggstatedeserializerespectively. This scenario was not handled properly in functionsfixeddecimalaggstateserializeandfixeddecimalaggstatedeserialize. This PR adds a check in these functions which will handle thisNULLvalue scenario.Also removed babel_money test from parallel_query_jdbc_schedule file, as the crash will be resolved by this PR.
Signed-off-by: Rohit Bhagat [email protected]
Issues Resolved
BABEL-4261
Test Scenarios Covered
Use case based - YES
Boundary conditions - NA
Arbitrary inputs - NA
Negative test cases - NA
Minor version upgrade tests - NA
Major version upgrade tests - NA
Performance tests - NA
Tooling impact - NA
Client tests - NA
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.