Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IDENTITY() function in SELECT-INTO #1659

Merged

Conversation

deepakshi-mittal
Copy link
Contributor

@deepakshi-mittal deepakshi-mittal commented Jul 28, 2023

Changes for Identity in Select Into statement
Added hooks for identity
Added fields in intoclause to pass information about identity column

Engine Pr: babelfish-for-postgresql/postgresql_modified_for_babelfish#166

Task : BABEL-539

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

macwoody
macwoody previously approved these changes Jul 28, 2023
contrib/babelfishpg_tsql/src/pl_handler.c Outdated Show resolved Hide resolved
contrib/babelfishpg_tsql/src/tsqlIface.cpp Outdated Show resolved Hide resolved
contrib/babelfishpg_tsql/src/pl_handler.c Outdated Show resolved Hide resolved
Changes for Identity in Select Into statement
Added hooks for identity
Added fields in intoclause to pass information about identity column

Task : BABEL-539

Signed-off-by: Deepakshi Mittal <[email protected]>
Added syntax error if query tries to calls internal function

Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-539

Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-539

Signed-off-by: Deepakshi Mittal <[email protected]>
Corrected formatting
Added case for decimal
used inbuilt function for getting procedure name
Added syntax error if identity_into function is called directly

Task: BABEL-539

Signed-off-by: Deepakshi Mittal <[email protected]>
Not required because no added test cases for callin these functions

Task: BABEL-539

Signed-off-by: Deepakshi Mittal <[email protected]>
Copy link
Contributor

@forestkeeper forestkeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@forestkeeper forestkeeper merged commit 1ece7f8 into babelfish-for-postgresql:BABEL_3_X_DEV Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants