-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support IDENTITY() function in SELECT-INTO #1659
Merged
forestkeeper
merged 6 commits into
babelfish-for-postgresql:BABEL_3_X_DEV
from
amazon-aurora:BABEL-539-1
Jul 31, 2023
Merged
Support IDENTITY() function in SELECT-INTO #1659
forestkeeper
merged 6 commits into
babelfish-for-postgresql:BABEL_3_X_DEV
from
amazon-aurora:BABEL-539-1
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macwoody
previously approved these changes
Jul 28, 2023
contrib/babelfishpg_tsql/src/backend_parser/gram-tsql-epilogue.y.c
Outdated
Show resolved
Hide resolved
Changes for Identity in Select Into statement Added hooks for identity Added fields in intoclause to pass information about identity column Task : BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
Added syntax error if query tries to calls internal function Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
Corrected formatting Added case for decimal used inbuilt function for getting procedure name Added syntax error if identity_into function is called directly Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
deepakshi-mittal
force-pushed
the
BABEL-539-1
branch
from
July 30, 2023 18:11
a21dbfb
to
e0774d6
Compare
Not required because no added test cases for callin these functions Task: BABEL-539 Signed-off-by: Deepakshi Mittal <[email protected]>
forestkeeper
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for Identity in Select Into statement
Added hooks for identity
Added fields in intoclause to pass information about identity column
Engine Pr: babelfish-for-postgresql/postgresql_modified_for_babelfish#166
Task : BABEL-539
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.