Fix Crash in FetchMoreBcpData #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are crashing here when the implicit batching of packets is happening at the very first phase i.e. reading column metadata phase because the table itself has huge number of columns. Inherently TDS is in a "miscellaneous" mem context during FETCH phase and the allocated pointer thus seems to crash for invalid context during pfree. To fix this we are appending the new packet's data during the FETCH phase rather than freeing the message data which we do in the PROCESS phase.
We are crashing here when the implicit batching of packets is happening at the very first phase i.e. reading column metadata phase because the table itself has huge number of columns. Inherently TDS is in a "miscellaneous" mem context during FETCH phase and the allocated pointer thus seems to crash for invalid context during pfree. To fix this we are appending the new packet's data during the FETCH phase rather than freeing the message data which we do in the PROCESS phase.
kuntalghosh
approved these changes
Jun 8, 2023
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jun 16, 2023
We are crashing here when the implicit batching of packets is happening at the very first phase i.e. reading column metadata phase because the table itself has huge number of columns. Inherently TDS is in a "miscellaneous" mem context during FETCH phase and the allocated pointer thus seems to crash for invalid context during pfree. To fix this we are appending the new packet's data during the FETCH phase rather than freeing the message data which we do in the PROCESS phase. Signed-off-by: Kushaal Shroff <[email protected]>
RIC06X
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jul 6, 2023
We are crashing here when the implicit batching of packets is happening at the very first phase i.e. reading column metadata phase because the table itself has huge number of columns. Inherently TDS is in a "miscellaneous" mem context during FETCH phase and the allocated pointer thus seems to crash for invalid context during pfree. To fix this we are appending the new packet's data during the FETCH phase rather than freeing the message data which we do in the PROCESS phase. Signed-off-by: Kushaal Shroff <[email protected]>
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jul 18, 2023
We are crashing here when the implicit batching of packets is happening at the very first phase i.e. reading column metadata phase because the table itself has huge number of columns. Inherently TDS is in a "miscellaneous" mem context during FETCH phase and the allocated pointer thus seems to crash for invalid context during pfree. To fix this we are appending the new packet's data during the FETCH phase rather than freeing the message data which we do in the PROCESS phase. Signed-off-by: Kushaal Shroff <[email protected]>
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jul 18, 2023
We are crashing here when the implicit batching of packets is happening at the very first phase i.e. reading column metadata phase because the table itself has huge number of columns. Inherently TDS is in a "miscellaneous" mem context during FETCH phase and the allocated pointer thus seems to crash for invalid context during pfree. To fix this we are appending the new packet's data during the FETCH phase rather than freeing the message data which we do in the PROCESS phase. Signed-off-by: Kushaal Shroff <[email protected]>
Santifedz
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Aug 7, 2023
We are crashing here when the implicit batching of packets is happening at the very first phase i.e. reading column metadata phase because the table itself has huge number of columns. Inherently TDS is in a "miscellaneous" mem context during FETCH phase and the allocated pointer thus seems to crash for invalid context during pfree. To fix this we are appending the new packet's data during the FETCH phase rather than freeing the message data which we do in the PROCESS phase. Signed-off-by: Kushaal Shroff <[email protected]>
shardgupta
pushed a commit
that referenced
this pull request
Oct 9, 2023
We are crashing here when the implicit batching of packets is happening at the very first phase i.e. reading column metadata phase because the table itself has huge number of columns. Inherently TDS is in a "miscellaneous" mem context during FETCH phase and the allocated pointer thus seems to crash for invalid context during pfree. To fix this we are appending the new packet's data during the FETCH phase rather than freeing the message data which we do in the PROCESS phase. Issues Resolved BABEL-4170 Signed-off-by: Kushaal Shroff [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Signed-off-by: Kushaal Shroff [email protected]
Issues Resolved
BABEL-4170
Test Scenarios Covered
Use case based -
Added the new test
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.