Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMS - Allow TSQL System views to display BYTEA datatype information #1532

Merged

Conversation

basasairohan
Copy link
Contributor

@basasairohan basasairohan commented May 31, 2023

Description

This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well.

Signed-off-by: Sai Rohan Basa [email protected]

Issues Resolved

BABEL-4191

Test Scenarios Covered

  • Use case based - N/A

  • Boundary conditions - N/A

  • Arbitrary inputs - N/A

  • Negative test cases - N/A

  • Minor version upgrade tests - Added in BABEL-SPCOLUMNS-vu-* and ISC-Columns-vu-*

  • Major version upgrade tests - Added in BABEL-SPCOLUMNS-vu-* and ISC-Columns-vu-*

  • Performance tests - N/A

  • Tooling impact - N/A

  • Client tests - N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@KushaalShroff KushaalShroff merged commit 05fb8be into babelfish-for-postgresql:BABEL_3_X_DEV May 31, 2023
basasairohan added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Jun 1, 2023
…abelfish-for-postgresql#1532)

This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well.

Signed-off-by: Sai Rohan Basa [email protected]
basasairohan added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Jun 1, 2023
…abelfish-for-postgresql#1532)

This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well.

Signed-off-by: Sai Rohan Basa [email protected]
basasairohan added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Jun 1, 2023
…abelfish-for-postgresql#1532)

This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well.

Signed-off-by: Sai Rohan Basa [email protected]
KushaalShroff pushed a commit that referenced this pull request Jun 1, 2023
…1532) (#1535)

This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well.

Signed-off-by: Sai Rohan Basa [email protected]
basasairohan added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Jun 1, 2023
…abelfish-for-postgresql#1532)

This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well.

Signed-off-by: Sai Rohan Basa [email protected]
basasairohan added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Jun 1, 2023
…abelfish-for-postgresql#1532)

This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well.

Signed-off-by: Sai Rohan Basa [email protected]
basasairohan added a commit to amazon-aurora/babelfish_extensions that referenced this pull request Jun 5, 2023
…abelfish-for-postgresql#1532)

This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well.

Signed-off-by: Sai Rohan Basa [email protected]
Santifedz pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Aug 7, 2023
…abelfish-for-postgresql#1532)

This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well.

Signed-off-by: Sai Rohan Basa [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants