-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMS - Allow TSQL System views to display BYTEA datatype information #1532
Merged
KushaalShroff
merged 3 commits into
babelfish-for-postgresql:BABEL_3_X_DEV
from
amazon-aurora:dms-bin
May 31, 2023
Merged
DMS - Allow TSQL System views to display BYTEA datatype information #1532
KushaalShroff
merged 3 commits into
babelfish-for-postgresql:BABEL_3_X_DEV
from
amazon-aurora:dms-bin
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KushaalShroff
approved these changes
May 31, 2023
basasairohan
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jun 1, 2023
…abelfish-for-postgresql#1532) This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well. Signed-off-by: Sai Rohan Basa [email protected]
basasairohan
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jun 1, 2023
…abelfish-for-postgresql#1532) This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well. Signed-off-by: Sai Rohan Basa [email protected]
basasairohan
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jun 1, 2023
…abelfish-for-postgresql#1532) This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well. Signed-off-by: Sai Rohan Basa [email protected]
KushaalShroff
pushed a commit
that referenced
this pull request
Jun 1, 2023
…1532) (#1535) This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well. Signed-off-by: Sai Rohan Basa [email protected]
basasairohan
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jun 1, 2023
…abelfish-for-postgresql#1532) This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well. Signed-off-by: Sai Rohan Basa [email protected]
basasairohan
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jun 1, 2023
…abelfish-for-postgresql#1532) This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well. Signed-off-by: Sai Rohan Basa [email protected]
basasairohan
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jun 5, 2023
…abelfish-for-postgresql#1532) This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well. Signed-off-by: Sai Rohan Basa [email protected]
Santifedz
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Aug 7, 2023
…abelfish-for-postgresql#1532) This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well. Signed-off-by: Sai Rohan Basa [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows Information_schema_tsql to return PG base types and sp_columns_100 to return data for bytea columns as well.
Signed-off-by: Sai Rohan Basa [email protected]
Issues Resolved
BABEL-4191
Test Scenarios Covered
Use case based - N/A
Boundary conditions - N/A
Arbitrary inputs - N/A
Negative test cases - N/A
Minor version upgrade tests - Added in BABEL-SPCOLUMNS-vu-* and ISC-Columns-vu-*
Major version upgrade tests - Added in BABEL-SPCOLUMNS-vu-* and ISC-Columns-vu-*
Performance tests - N/A
Tooling impact - N/A
Client tests - N/A
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.