Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ODBC test function #1522

Conversation

ZhenyeLee
Copy link
Contributor

@ZhenyeLee ZhenyeLee commented May 27, 2023

Description

The ODBC test failed in our pipeline, the root cause is when reading the text from file, the buffer doesn’t include any EOF so we get some random message in the end.

Issues Resolved

NO-JIRA

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Zhenye Li <[email protected]>
@ZhenyeLee ZhenyeLee changed the title Correct ODBC output file Correct ODBC test file May 27, 2023
@ZhenyeLee ZhenyeLee requested a review from forestkeeper May 30, 2023 16:35
Copy link
Contributor

@forestkeeper forestkeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forestkeeper forestkeeper merged commit ec44be4 into babelfish-for-postgresql:BABEL_3_X_DEV May 30, 2023
@ZhenyeLee ZhenyeLee changed the title Correct ODBC test file Correct ODBC test funcrion May 30, 2023
@ZhenyeLee ZhenyeLee changed the title Correct ODBC test funcrion Correct ODBC test function May 30, 2023
Santifedz pushed a commit to amazon-aurora/babelfish_extensions that referenced this pull request Aug 7, 2023
Previously when reading the text from file, the buffer doesn’t include any EOF so we get some random message in the end.

Task: No JIRA
Signed-off-by: Zhenye Li <[email protected]>
Co-authored-by: Zhenye Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants