create proc/func/trigger, create/drop database, transaction statements are not being tracked by the extensions which utilize processutility hook #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called.
Created a hook for that and called it inside relevant
ProcessUtility function.
Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called.
Created a hook for that and called it inside relevant
ProcessUtility function.
Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called.
Created a hook for that and called it inside relevant
ProcessUtility function.
Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
added 3 commits
May 3, 2023 08:22
Subsequent processutility hooks after bbf_processutilty are not being called.
Created a hook for that and called it inside relevant
ProcessUtility function.
Signed-off-by: Kritika <[email protected]>
Subsequent processutility hooks after bbf_processutilty are not being called.
Created a hook for that and called it inside relevant
ProcessUtility function.
Signed-off-by: Kritika <[email protected]>
surendravishnoi
previously approved these changes
May 8, 2023
Subsequent processutility hooks after bbf_processutilty are not being called.
Created a hook for that and called it inside relevant
ProcessUtility function.
Signed-off-by: Kritika <[email protected]>
surendravishnoi
previously approved these changes
May 8, 2023
added 2 commits
May 16, 2023 08:18
Subsequent processutility hooks after bbf_processutilty are not being called. Created a hook for that and called it inside relevant ProcessUtility function. Signed-off-by: Kritika <[email protected]>
HarshLunagariya
suggested changes
Jun 12, 2023
…ked by extensions in BBF Signed-off-by: Kritika <[email protected]>
HarshLunagariya
approved these changes
Jun 12, 2023
kritika-0601
changed the title
shardgupta
approved these changes
Jun 13, 2023
RIC06X
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jul 6, 2023
…s are not being tracked by the extensions which utilize processutility hook (babelfish-for-postgresql#1424) Currently statements like create proc/func/trigger/database, drop database and transaction statements are not being tracked by the extensions which utilises the processutility hooks in Babelfish. Above issue happens because bbf_processutility doesn't call subsequent/previous processutility hook for above statements due to which these subsequent extension hooks are not being executed. This commit resolves above issue by adding a custom processutility hook in engine to execute above Babelfish statements so that execution happens at last step of processutility hook chain which makes sure that subsequent extension hooks are executed. Before: processUtility_hooks()-> ... -> bbf_processUtility_hook() -> executes above statements -> execution completed/doesn't return to previous hook execution or doesn't execute subsequent hooks After: processUtility_hooks()-> ... -> bbf_processUtility_hook() -> ... -> processUtility_hooks()-> ... -> Standard_processUtility()-> executes above statements using custom hook -> returns to previous hook execution Task: BABEL-4218 Link for engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#127 Signed-off-by: Kritika <[email protected]>
Santifedz
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Aug 7, 2023
…s are not being tracked by the extensions which utilize processutility hook (babelfish-for-postgresql#1424) Currently statements like create proc/func/trigger/database, drop database and transaction statements are not being tracked by the extensions which utilises the processutility hooks in Babelfish. Above issue happens because bbf_processutility doesn't call subsequent/previous processutility hook for above statements due to which these subsequent extension hooks are not being executed. This commit resolves above issue by adding a custom processutility hook in engine to execute above Babelfish statements so that execution happens at last step of processutility hook chain which makes sure that subsequent extension hooks are executed. Before: processUtility_hooks()-> ... -> bbf_processUtility_hook() -> executes above statements -> execution completed/doesn't return to previous hook execution or doesn't execute subsequent hooks After: processUtility_hooks()-> ... -> bbf_processUtility_hook() -> ... -> processUtility_hooks()-> ... -> Standard_processUtility()-> executes above statements using custom hook -> returns to previous hook execution Task: BABEL-4218 Link for engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#127 Signed-off-by: Kritika <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently statements like create proc/func/trigger/database, drop database and transaction statements are not being tracked by the extensions which utilises the processutility hooks in Babelfish. Above issue happens because bbf_processutility doesn't call subsequent/previous processutility hook for above statements due to which these subsequent extension hooks are not being executed.
This commit resolves above issue by adding a custom processutility hook in engine to execute above Babelfish statements so that execution happens at last step of processutility hook chain which makes sure that subsequent extension hooks are executed.
Before:
processUtility_hooks()-> ... -> bbf_processUtility_hook() -> executes above statements -> execution completed/doesn't return to previous hook execution or doesn't execute subsequent hooks
After:
processUtility_hooks()-> ... -> bbf_processUtility_hook() -> ... -> processUtility_hooks()-> ... -> Standard_processUtility()-> executes above statements using custom hook -> returns to previous hook execution
Task: BABEL-4218
Link for engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#127
Since this PR includes calling the engine side function to extension side using hook, we do not require extra test scenarios to test it, it is already being covered in previous tests.
We have separate test PR for testing pg_stat_statements extension.
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.