Date functions returns time of transaction instead of time of query (#…

…1693)

Get Current Date/time type functions inside a batch were returning the same datetime. This was because we were calling SetCurrentStatementStartTimestamp only at batch level. To fix this, we now call SetCurrentStatementStartTimestamp at statement level.
Moreover, this commit removes the extra definition for GETUTCDATE which was causing behaviour differences.

Issues Resolved
BABEL-4187

Signed-off-by: Kushaal Shroff [email protected]

contrib/babelfishpg_tsql/sql/sys_functions.sql

@@ -1676,12 +1676,6 @@ $BODY$
 STRICT
 LANGUAGE sql IMMUTABLE;
 
-CREATE OR REPLACE FUNCTION sys.GETUTCDATE() RETURNS sys.DATETIME AS
-$BODY$
-SELECT CAST(CURRENT_TIMESTAMP AT TIME ZONE 'UTC'::pg_catalog.text AS sys.DATETIME);
-$BODY$
-LANGUAGE SQL STABLE PARALLEL SAFE;
-
 -- These come from the built-in pg_catalog.count in pg_aggregate.dat
 CREATE AGGREGATE sys.count(*)
 (

contrib/babelfishpg_tsql/src/iterative_exec.c

@@ -1414,6 +1414,9 @@ exec_stmt_iterative(PLtsql_execstate *estate, ExecCodes *exec_codes, ExecConfig_
 
 			reset_exec_error_data(estate);
 
+			/* Set the current Statement Start time at satement level and not at batch. */
+			SetCurrentStatementStartTimestamp();
+
 			/*
 			 * Let the protocol plugin know that we are about to execute this
 			 * statement