bump Babel 8 to 8.0.0-alpha.12 #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for babel-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JLHwung
force-pushed
the
bump-babel-8
branch
from
680d6fe to
b99311f
Compare
❌ Deploy Preview for babel failed.
|
✅ Deploy Preview for babel ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
11 tasks
|
This has been fixed in babel/babel-loader#1007. |
|
@liuxingbaoyu Thank you! I guess the incorrect argument error was thrown asynchronously, otherwise it should have been caught in the catch clause. @nicolo-ribaudo Could you take a look at babel/babel-loader#1037 and do a release from the 9.x branch? |
JLHwung
force-pushed
the
bump-babel-8
branch
from
b99311f to
04e0230
Compare
|
CI is green again thanks to the babel-loader upgrade. |
liuxingbaoyu
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build is failing when bumping from 8.0.0-alpha.2 to 8.0.0-alpha.12.
The error is confusing since babel-loader 9 did not issue
loadPartialConfigcalls. I am still investigating the diff highlight regression, if you have bandwidth, please take a look.To reproduce the build error, one can run
yarn start:repl.