Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before Alpha Release #31

Closed
13 tasks done
hzoo opened this issue Jun 22, 2016 · 5 comments
Closed
13 tasks done

Before Alpha Release #31

hzoo opened this issue Jun 22, 2016 · 5 comments
Labels
help wanted Tag: Chore Pull Request updating grunt tasks etc...

Comments

@hzoo
Copy link
Member

hzoo commented Jun 22, 2016

can't we just make the babel-minify executable a child.process that calls out to the babel CLI just with a --presets minify argument appended?

  • reasoning, and how it works (explanation about how babel is a compiler and optimization is just another thing that it can do just like converting es2015, it should be faster since it's the same tool and can be run as part of your babel build)


After

@fregante
Copy link
Contributor

fregante commented Jul 7, 2016

babel-minify is taken and there's actually some progress there:

https://www.npmjs.com/package/babel-minify

https://github.com/boopathi/babel-minify (since June 2nd)

Would it make sense to join forces?

@hzoo
Copy link
Member Author

hzoo commented Jul 7, 2016

Yeah I've talked with them before and on slack - yeah probably? Maybe we should just invite to repo now - I can ask

boopathi/babel-minify#1

@fregante
Copy link
Contributor

fregante commented Jul 16, 2016

I'd also add:

I suppose it's as easy as applying this preset only on the production ENV

@hzoo
Copy link
Member Author

hzoo commented Jul 19, 2016

Added ^, and @boopathi is added now

@hzoo hzoo changed the title Before Release Before Alpha Release Aug 2, 2016
@kangax kangax added the Tag: Chore Pull Request updating grunt tasks etc... label Aug 10, 2016
@hzoo
Copy link
Member Author

hzoo commented Aug 29, 2016

I think we did most of these

@hzoo hzoo closed this as completed Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Tag: Chore Pull Request updating grunt tasks etc...
Projects
None yet
Development

No branches or pull requests

3 participants