Fix compatibility with ember-auto-import. #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[email protected] accidentally broke compatibility with ember-auto-import when it fixed `buildBabelOptions` to only return custom babel config **not** broccoli-babel-transpiler config. This fixes that compatiblity in the case where `babelAddon.buildBabelOptions()` is called, but still preserves the ability to get _either_ the broccoli-babel-transpiler config _or_ the `@babel/core` config.
|
Thanks for confirming @kpfefferle! I didn't realize this was also the cause there, but it definitely makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected] accidentally broke compatibility with ember-auto-import when it fixed
buildBabelOptionsto only return custom babel config not broccoli-babel-transpiler config.This fixes that compatiblity in the case where
babelAddon.buildBabelOptions()is called, but still preserves the ability to get either the broccoli-babel-transpiler config or the@babel/coreconfig.Fixes embroider-build/ember-auto-import#359
Fixes #389
Related to embroider-build/ember-auto-import#362