Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading from 7.23.1 to 7.24.0 breaks various NPM module imports #386

Closed
kpfefferle opened this issue Mar 8, 2021 · 3 comments
Closed

Comments

@kpfefferle
Copy link

I am unable to upgrade some of my projects to [email protected] because it breaks importing from some NPM modules. So far I have seen this issue with the following packages:

  • Faker: import faker from 'faker';
  • Luxon: import { DateTime } from 'luxon';

Both of these worked fine in my Ember projects up through [email protected], but with [email protected] they error out with Error: Could not find module [MODULE] imported from [FILE]

@rwjblue
Copy link
Member

rwjblue commented Mar 8, 2021

Can you make a small repro?

@kpfefferle
Copy link
Author

My initial attempt to make a small repro using only these addons is not generating the same errors I was seeing in my other application. I'll close this for now while I investigate what else might be causing this, and I'll reopen later if needed.

@rwjblue
Copy link
Member

rwjblue commented Mar 10, 2021

kk, thank you for reporting back! Please do let me know if you are able to track down a repro, I definitely want to make sure we aren't breaking things for folks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants