-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure @ember/application/deprecations
is stripped in addition to @ember/debug
.
#286
Conversation
317daf5
to
e1d6f9b
Compare
e1d6f9b
to
828de36
Compare
Co-Authored-By: Robert Jackson <[email protected]>
Co-Authored-By: Robert Jackson <[email protected]>
thank you @rwjblue, accepted all those changes |
@ember/application/deprecations
is stripped in addition to @ember/debug
.
@bekzod - I've pushed a few changes:
Should be good to land once CI is finished... |
|
||
return [[require.resolve('babel-plugin-debug-macros'), options]]; | ||
[ | ||
require.resolve('babel-plugin-debug-macros'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running the same plugin twice seems unfortunate, can the primary plugin simply be taught how to handle this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already support arbitrary module paths with flags
, but not with debugTools
. We can definitely update babel-plugin-debug-macros
to support that though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
investigating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue seems to have been a monorepo with a shared lockfile resulted in an incomplete semver drift of relevant dependencies, upgrading all repos contained within the monorepo fixed the issues.
emberjs/ember.js#17926 (comment)