Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @babel/polyfill dependency #200

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Remove @babel/polyfill dependency #200

merged 2 commits into from
Jun 14, 2021

Conversation

nlfurniss
Copy link
Contributor

@nlfurniss nlfurniss commented Apr 29, 2021 •
edited
Loading

Summary

@babel/polyfill was removed in #191 so is not longer needed as a dep

Testing Done

yarn run tests:all passes locally

@nicolo-ribaudo
Copy link
Member

Where was @babel/polyfill loaded? You probably also need to update it there 🤔

@rwjblue
Copy link
Member

rwjblue commented Apr 30, 2021

I think we already removed the usage (we have been queuing up for a major release).

Can you double check that @nlfurniss ?

@nlfurniss nlfurniss force-pushed the remove-babel-polyfill branch from bb222c5 to 5179a95 Compare April 30, 2021 02:19
@nlfurniss nlfurniss changed the title Remove @babel/polyfill in favor of core-js Remove @babel/polyfill Apr 30, 2021
@nlfurniss
Copy link
Contributor Author

I think we already removed the usage (we have been queuing up for a major release).

Can you double check that @nlfurniss ?

Yup, which explains its absence 😝 . Updated the PR to simply remove it.

@SergeAstapov SergeAstapov mentioned this pull request May 22, 2021
Closed
@rwjblue
Copy link
Member

rwjblue commented Jun 11, 2021

@nlfurniss - Would you mind rebasing? I re-enabled CI so it should run now..

@nlfurniss
Copy link
Contributor Author

@nlfurniss - Would you mind rebasing? I re-enabled CI so it should run now..

Pushed an empty commit and all the checks are ✅

@rwjblue rwjblue changed the title Remove @babel/polyfill Remove @babel/polyfill dependency Jun 14, 2021
@rwjblue rwjblue merged commit 416732d into babel:master Jun 14, 2021
@rwjblue
Copy link
Member

rwjblue commented Jun 14, 2021

Thanks @nlfurniss!

@nlfurniss nlfurniss deleted the remove-babel-polyfill branch June 14, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlfurniss @nicolo-ribaudo @rwjblue