Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Allow Flowtype's imports and exports when sourceType:script is set. #771

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Allow Flowtype's imports and exports when sourceType:script is set. #771

merged 1 commit into from
Oct 27, 2017

Conversation

loganfsmyth
Copy link
Member

Q A
Bug fix? Maybe?
Breaking change? N
New feature?
Deprecations?
Spec compliancy?
Tests added/pass?
Fixed tickets Fixes #726
License MIT

This allows the following syntax, even when sourceType: "script" is set:

import type Foo from "";
import typeof Foo from "";
export type Foo = number;
export opaque type Foo = number;
export type * from "";

since Flowtype doesn't really care about sourceType it doesn't make sense for Babel to limit these.

Curious to see if people feel otherwise.

@loganfsmyth loganfsmyth merged commit e4bcd1d into babel:master Oct 27, 2017
@loganfsmyth loganfsmyth deleted the flow-module-in-script branch October 27, 2017 18:55
@loganfsmyth loganfsmyth mentioned this pull request Nov 10, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

Assignees
No one assigned
Labels
area: flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we allow Flowtype import type statements when sourceType:script?
2 participants
@loganfsmyth @existentialism