This repository has been archived by the owner on May 19, 2018. It is now read-only.
Fix negative number literal typeannotations #366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently negative number literal type annotations contain the wrong raw value:
http://astexplorer.net/#/gist/f6cb8e0c848b800f6fdf2e1b64cad131/90e051a59cdf7e4fa88e79c22f6567dc1c451e45
The raw value is
"1"
instead of"-1"
. The flow parser is doing the correct thing.Also use parseLiteral() to parser string and number literal typeannotations
so that future changes (estree) to literals are also reflected to flow.